mirror of
https://github.com/slint-ui/slint.git
synced 2025-08-31 23:57:26 +00:00

We need to draw the background over the rotated rectangle otherwise we don't fill the whole background. Regression from https://github.com/slint-ui/slint/pull/7685 (also cleanup a useless blend that was leftover from the same change) Adapt the screenshot test to have at least one non-square "window" so that we catch the problem in the future
341 lines
12 KiB
Rust
341 lines
12 KiB
Rust
// Copyright © SixtyFPS GmbH <info@slint.dev>
|
|
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
|
|
|
|
// cSpell: ignore powf
|
|
|
|
use std::rc::Rc;
|
|
|
|
use crossterm::style::Stylize;
|
|
|
|
use i_slint_core::graphics::{euclid, IntRect, Rgb8Pixel, SharedPixelBuffer};
|
|
use i_slint_core::lengths::LogicalRect;
|
|
use i_slint_core::platform::PlatformError;
|
|
use i_slint_core::renderer::RendererSealed;
|
|
use i_slint_core::software_renderer::{
|
|
LineBufferProvider, MinimalSoftwareWindow, RenderingRotation,
|
|
};
|
|
|
|
pub struct SwrTestingBackend {
|
|
window: Rc<MinimalSoftwareWindow>,
|
|
}
|
|
|
|
impl i_slint_core::platform::Platform for SwrTestingBackend {
|
|
fn create_window_adapter(
|
|
&self,
|
|
) -> Result<Rc<dyn i_slint_core::platform::WindowAdapter>, PlatformError> {
|
|
Ok(self.window.clone())
|
|
}
|
|
|
|
fn duration_since_start(&self) -> core::time::Duration {
|
|
core::time::Duration::from_millis(i_slint_core::animations::current_tick().0)
|
|
}
|
|
}
|
|
|
|
pub fn init_swr() -> Rc<MinimalSoftwareWindow> {
|
|
let window = MinimalSoftwareWindow::new(
|
|
i_slint_core::software_renderer::RepaintBufferType::ReusedBuffer,
|
|
);
|
|
|
|
i_slint_core::platform::set_platform(Box::new(SwrTestingBackend { window: window.clone() }))
|
|
.unwrap();
|
|
|
|
window
|
|
}
|
|
|
|
pub fn image_buffer(path: &str) -> Result<SharedPixelBuffer<Rgb8Pixel>, image::ImageError> {
|
|
image::open(path).map(|image| {
|
|
let image = image.into_rgb8();
|
|
SharedPixelBuffer::<Rgb8Pixel>::clone_from_slice(
|
|
image.as_raw(),
|
|
image.width(),
|
|
image.height(),
|
|
)
|
|
})
|
|
}
|
|
|
|
pub fn screenshot(
|
|
window: Rc<MinimalSoftwareWindow>,
|
|
rotated: RenderingRotation,
|
|
) -> SharedPixelBuffer<Rgb8Pixel> {
|
|
let size = window.size();
|
|
let width = size.width;
|
|
let height = size.height;
|
|
|
|
let mut buffer = match rotated {
|
|
RenderingRotation::Rotate90 | RenderingRotation::Rotate270 => {
|
|
SharedPixelBuffer::<Rgb8Pixel>::new(height, width)
|
|
}
|
|
_ => SharedPixelBuffer::<Rgb8Pixel>::new(width, height),
|
|
};
|
|
|
|
// render to buffer
|
|
window.request_redraw();
|
|
window.draw_if_needed(|renderer| {
|
|
renderer.mark_dirty_region(
|
|
LogicalRect::from_size(euclid::size2(width as f32, height as f32)).into(),
|
|
);
|
|
renderer.set_rendering_rotation(rotated);
|
|
let stride = buffer.width() as usize;
|
|
renderer.render(buffer.make_mut_slice(), stride);
|
|
renderer.set_rendering_rotation(RenderingRotation::NoRotation);
|
|
});
|
|
|
|
buffer
|
|
}
|
|
|
|
struct TestingLineBuffer<'a> {
|
|
buffer: &'a mut [Rgb8Pixel],
|
|
stride: usize,
|
|
region: Option<IntRect>,
|
|
}
|
|
|
|
impl LineBufferProvider for TestingLineBuffer<'_> {
|
|
type TargetPixel = Rgb8Pixel;
|
|
|
|
fn process_line(
|
|
&mut self,
|
|
line: usize,
|
|
range: core::ops::Range<usize>,
|
|
render_fn: impl FnOnce(&mut [Self::TargetPixel]),
|
|
) {
|
|
if let Some(r) = self.region.map(|r| r.cast::<usize>()) {
|
|
assert!(r.y_range().contains(&line), "line {line} out of range {r:?}");
|
|
assert_eq!(r.cast().x_range(), range);
|
|
}
|
|
let start = line * self.stride + range.start;
|
|
let end = line * self.stride + range.end;
|
|
render_fn(&mut self.buffer[start..end]);
|
|
}
|
|
}
|
|
|
|
fn color_difference(lhs: &Rgb8Pixel, rhs: &Rgb8Pixel) -> f32 {
|
|
((rhs.r as f32 - lhs.r as f32).powf(2.)
|
|
+ (rhs.g as f32 - lhs.g as f32).powf(2.)
|
|
+ (rhs.b as f32 - lhs.b as f32).powf(2.))
|
|
.sqrt()
|
|
}
|
|
|
|
#[derive(Default, Clone)]
|
|
pub struct TestCaseOptions {
|
|
/// How much we allow the maximum pixel difference to be when operating a screen rotation
|
|
pub rotation_threshold: f32,
|
|
|
|
/// When true, we don't compare screenshots rendered with clipping
|
|
pub skip_clipping: bool,
|
|
}
|
|
|
|
fn compare_images(
|
|
reference_path: &str,
|
|
screenshot: &SharedPixelBuffer<Rgb8Pixel>,
|
|
rotated: RenderingRotation,
|
|
options: &TestCaseOptions,
|
|
) -> Result<(), String> {
|
|
let compare = || {
|
|
let reference = image_buffer(reference_path)
|
|
.map_err(|image_err| format!("error loading reference image: {image_err:#}"))?;
|
|
|
|
let mut ref_size = reference.size();
|
|
if matches!(rotated, RenderingRotation::Rotate90 | RenderingRotation::Rotate270) {
|
|
std::mem::swap(&mut ref_size.width, &mut ref_size.height);
|
|
}
|
|
if ref_size != screenshot.size() {
|
|
return Err(format!(
|
|
"image sizes don't match. reference size {:#?} rendered size {:#?}",
|
|
reference.size(),
|
|
screenshot.size()
|
|
));
|
|
}
|
|
if reference.as_bytes() == screenshot.as_bytes() && rotated != RenderingRotation::NoRotation
|
|
{
|
|
return Ok(());
|
|
}
|
|
|
|
let idx = |x: u32, y: u32| -> u32 {
|
|
match rotated {
|
|
RenderingRotation::Rotate90 => (reference.height() - x - 1) * reference.width() + y,
|
|
RenderingRotation::Rotate180 => {
|
|
(reference.height() - y - 1) * reference.width() + reference.width() - x - 1
|
|
}
|
|
RenderingRotation::Rotate270 => x * reference.width() + reference.width() - y - 1,
|
|
_ => y * reference.width() + x,
|
|
}
|
|
};
|
|
|
|
let fold_pixel = |(failure_count, max_color_difference): (usize, f32),
|
|
(reference_pixel, screenshot_pixel)| {
|
|
(
|
|
failure_count + (reference_pixel != screenshot_pixel) as usize,
|
|
max_color_difference.max(color_difference(reference_pixel, screenshot_pixel)),
|
|
)
|
|
};
|
|
|
|
let (failed_pixel_count, max_color_difference) = if rotated != RenderingRotation::NoRotation
|
|
{
|
|
let mut failure_count = 0usize;
|
|
let mut max_color_difference = 0.0f32;
|
|
for y in 0..screenshot.height() {
|
|
for x in 0..screenshot.width() {
|
|
let pa = &reference.as_slice()[idx(x, y) as usize];
|
|
let pb = &screenshot.as_slice()[(y * screenshot.width() + x) as usize];
|
|
(failure_count, max_color_difference) =
|
|
fold_pixel((failure_count, max_color_difference), (pa, pb));
|
|
}
|
|
}
|
|
(failure_count, max_color_difference)
|
|
} else {
|
|
reference
|
|
.as_slice()
|
|
.iter()
|
|
.zip(screenshot.as_slice().iter())
|
|
.fold((0usize, 0.0f32), fold_pixel)
|
|
};
|
|
if max_color_difference < 0.1 {
|
|
return Ok(());
|
|
}
|
|
let percentage_different = failed_pixel_count * 100 / reference.as_slice().len();
|
|
if rotated != RenderingRotation::NoRotation
|
|
&& (percentage_different < 1 || max_color_difference < options.rotation_threshold)
|
|
{
|
|
return Ok(());
|
|
}
|
|
|
|
for y in 0..screenshot.height() {
|
|
for x in 0..screenshot.width() {
|
|
let pa = reference.as_slice()[idx(x, y) as usize];
|
|
let pb = screenshot.as_slice()[(y * screenshot.width() + x) as usize];
|
|
let ca = crossterm::style::Color::Rgb { r: pa.r, g: pa.g, b: pa.b };
|
|
let cb = crossterm::style::Color::Rgb { r: pb.r, g: pb.g, b: pb.b };
|
|
if pa == pb {
|
|
eprint!("{}", crossterm::style::style("██").on(ca).with(cb));
|
|
} else if color_difference(&pa, &pb) >= 1.75 {
|
|
eprint!(
|
|
"{}{}",
|
|
crossterm::style::style("•").on(ca).slow_blink().red(),
|
|
crossterm::style::style("•").on(cb).slow_blink().green()
|
|
);
|
|
} else {
|
|
eprint!(
|
|
"{}{}",
|
|
crossterm::style::style(".").on(ca).slow_blink().red(),
|
|
crossterm::style::style(".").on(cb).slow_blink().green()
|
|
);
|
|
}
|
|
}
|
|
eprintln!();
|
|
}
|
|
|
|
Err(format!("images are not equal. Percentage of pixels that are different: {}. Maximum color difference: {}", failed_pixel_count * 100 / reference.as_slice().len(), max_color_difference))
|
|
};
|
|
|
|
let result = compare();
|
|
|
|
if result.is_err()
|
|
&& rotated == RenderingRotation::NoRotation
|
|
&& std::env::var("SLINT_CREATE_SCREENSHOTS").is_ok_and(|var| var == "1")
|
|
{
|
|
eprintln!("saving rendered image as comparison to reference failed");
|
|
image::save_buffer(
|
|
reference_path,
|
|
screenshot.as_bytes(),
|
|
screenshot.width(),
|
|
screenshot.height(),
|
|
image::ColorType::Rgb8,
|
|
)
|
|
.unwrap();
|
|
}
|
|
|
|
result
|
|
}
|
|
|
|
pub fn assert_with_render(
|
|
path: &str,
|
|
window: Rc<MinimalSoftwareWindow>,
|
|
options: &TestCaseOptions,
|
|
) {
|
|
for rotation in [
|
|
RenderingRotation::NoRotation,
|
|
RenderingRotation::Rotate180,
|
|
RenderingRotation::Rotate90,
|
|
RenderingRotation::Rotate270,
|
|
] {
|
|
let rendering = screenshot(window.clone(), rotation);
|
|
if let Err(reason) = compare_images(path, &rendering, rotation, options) {
|
|
panic!("Image comparison failure for {path} ({rotation:?}): {reason}");
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn assert_with_render_by_line(
|
|
path: &str,
|
|
window: Rc<MinimalSoftwareWindow>,
|
|
options: &TestCaseOptions,
|
|
) {
|
|
let s = window.size();
|
|
let mut rendering = SharedPixelBuffer::<Rgb8Pixel>::new(s.width, s.height);
|
|
|
|
screenshot_render_by_line(window.clone(), None, &mut rendering);
|
|
if let Err(reason) = compare_images(path, &rendering, RenderingRotation::NoRotation, options) {
|
|
panic!("Image comparison failure for line-by-line rendering for {path}: {reason}");
|
|
}
|
|
|
|
// Try to render a clipped version (to simulate partial rendering) and it should be exactly the same
|
|
let region = euclid::rect(s.width / 4, s.height / 4, s.width / 2, s.height / 2).cast::<usize>();
|
|
for y in region.y_range() {
|
|
let stride = rendering.width() as usize;
|
|
// fill with garbage
|
|
rendering.make_mut_slice()[y * stride..][region.x_range()].fill(Rgb8Pixel::new(
|
|
((y << 3) & 0xff) as u8,
|
|
0,
|
|
255,
|
|
));
|
|
}
|
|
screenshot_render_by_line(window, Some(region.cast()), &mut rendering);
|
|
if !options.skip_clipping {
|
|
if let Err(reason) =
|
|
compare_images(path, &rendering, RenderingRotation::NoRotation, options)
|
|
{
|
|
panic!("Partial rendering image comparison failure for line-by-line rendering for {path}: {reason}");
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn screenshot_render_by_line(
|
|
window: Rc<MinimalSoftwareWindow>,
|
|
region: Option<IntRect>,
|
|
buffer: &mut SharedPixelBuffer<Rgb8Pixel>,
|
|
) {
|
|
// render to buffer
|
|
window.request_redraw();
|
|
|
|
window.draw_if_needed(|renderer| {
|
|
match region {
|
|
None => renderer.mark_dirty_region(
|
|
LogicalRect::from_size(euclid::size2(
|
|
buffer.width() as f32,
|
|
buffer.height() as f32,
|
|
))
|
|
.into(),
|
|
),
|
|
Some(r) => renderer.mark_dirty_region(
|
|
(euclid::Rect::from_untyped(&r.cast()) / window.scale_factor()).into(),
|
|
),
|
|
}
|
|
renderer.render_by_line(TestingLineBuffer {
|
|
stride: buffer.width() as usize,
|
|
buffer: buffer.make_mut_slice(),
|
|
region,
|
|
});
|
|
});
|
|
}
|
|
|
|
pub fn save_screenshot(path: &str, window: Rc<MinimalSoftwareWindow>) {
|
|
let buffer = screenshot(window.clone(), RenderingRotation::NoRotation);
|
|
image::save_buffer(
|
|
path,
|
|
buffer.as_bytes(),
|
|
window.size().width,
|
|
window.size().height,
|
|
image::ColorType::Rgb8,
|
|
)
|
|
.unwrap();
|
|
}
|