mirror of
				https://github.com/slint-ui/slint.git
				synced 2025-11-03 21:24:17 +00:00 
			
		
		
		
	This is a hacky approach, but does help a lot with the tedious fixes. See https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_map_or ``` __CARGO_FIX_YOLO=1 cargo clippy --fix --all-targets --workspace --exclude gstreamer-player --exclude i-slint-backend-linuxkms --exclude uefi-demo --exclude ffmpeg -- -A clippy::all -W clippy::unnecessary_map_or cargo fmt --all ```
		
			
				
	
	
		
			322 lines
		
	
	
	
		
			9.9 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
			
		
		
	
	
			322 lines
		
	
	
	
		
			9.9 KiB
		
	
	
	
		
			Rust
		
	
	
	
	
	
// Copyright © SixtyFPS GmbH <info@slint.dev>
 | 
						|
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
 | 
						|
 | 
						|
//! This test is trying to compile all the *.slint files in the sub directories and check that compilation
 | 
						|
//! errors are properly reported
 | 
						|
//!
 | 
						|
//! The .slint files can have comments like this:
 | 
						|
//! ```ignore
 | 
						|
//!  hi ho
 | 
						|
//!  // ^error{some_regexp}
 | 
						|
//! ```
 | 
						|
//!
 | 
						|
//! Meaning that there must an error following with an error message for that regular expression in the position
 | 
						|
//! on the line above at the column pointed by the caret.
 | 
						|
//! If there are two carets: ` ^^error{some_regexp}`  then it means two line above, and so on with more carets.
 | 
						|
//! `^warning{regexp}` is also supported.
 | 
						|
 | 
						|
use i_slint_compiler::ComponentSelection;
 | 
						|
use std::path::{Path, PathBuf};
 | 
						|
 | 
						|
#[test]
 | 
						|
fn syntax_tests() -> std::io::Result<()> {
 | 
						|
    use rayon::prelude::*;
 | 
						|
 | 
						|
    if let Some(specific_test) = std::env::args()
 | 
						|
        .skip(1)
 | 
						|
        .skip_while(|arg| arg.starts_with("--") || arg == "syntax_tests")
 | 
						|
        .next()
 | 
						|
    {
 | 
						|
        let mut path = std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR"));
 | 
						|
        path.push("tests");
 | 
						|
        path.push(specific_test);
 | 
						|
        assert!(process_file(&path)?);
 | 
						|
        return Ok(());
 | 
						|
    }
 | 
						|
 | 
						|
    let mut test_entries = Vec::new();
 | 
						|
    for entry in std::fs::read_dir(format!("{}/tests/syntax", env!("CARGO_MANIFEST_DIR")))? {
 | 
						|
        let entry = entry?;
 | 
						|
        if entry.file_type().is_ok_and(|f| f.is_dir()) {
 | 
						|
            let path = entry.path();
 | 
						|
            for test_entry in path.read_dir()? {
 | 
						|
                let test_entry = test_entry?;
 | 
						|
                let path = test_entry.path();
 | 
						|
                if let Some(ext) = path.extension() {
 | 
						|
                    if ext == "60" || ext == "slint" {
 | 
						|
                        test_entries.push(path);
 | 
						|
                    }
 | 
						|
                }
 | 
						|
            }
 | 
						|
        }
 | 
						|
    }
 | 
						|
 | 
						|
    let success = test_entries
 | 
						|
        .par_iter()
 | 
						|
        .try_fold(
 | 
						|
            || true,
 | 
						|
            |mut success, path| {
 | 
						|
                success &= process_file(path)?;
 | 
						|
                Ok::<bool, std::io::Error>(success)
 | 
						|
            },
 | 
						|
        )
 | 
						|
        .try_reduce(|| true, |success, result| Ok(success & result))?;
 | 
						|
 | 
						|
    assert!(success);
 | 
						|
 | 
						|
    Ok(())
 | 
						|
}
 | 
						|
 | 
						|
fn process_file(path: &std::path::Path) -> std::io::Result<bool> {
 | 
						|
    let source = std::fs::read_to_string(path)?;
 | 
						|
    if path.to_str().unwrap_or("").contains("bom-") && !source.starts_with("\u{FEFF}") {
 | 
						|
        // make sure that the file still contains BOM and it wasn't remove by some tools
 | 
						|
        return Err(std::io::Error::other(format!(
 | 
						|
            "{path:?} does not contains BOM while it should"
 | 
						|
        )));
 | 
						|
    }
 | 
						|
    std::panic::catch_unwind(|| process_file_source(path, source, false)).unwrap_or_else(|err| {
 | 
						|
        println!("Panic while processing {}: {:?}", path.display(), err);
 | 
						|
        Ok(false)
 | 
						|
    })
 | 
						|
}
 | 
						|
 | 
						|
fn process_diagnostics(
 | 
						|
    compile_diagnostics: &i_slint_compiler::diagnostics::BuildDiagnostics,
 | 
						|
    path: &Path,
 | 
						|
    source: &str,
 | 
						|
    _silent: bool,
 | 
						|
) -> std::io::Result<bool> {
 | 
						|
    let mut success = true;
 | 
						|
 | 
						|
    let path = canonical(path);
 | 
						|
 | 
						|
    let mut diags = compile_diagnostics
 | 
						|
        .iter()
 | 
						|
        .filter(|d| {
 | 
						|
            canonical(
 | 
						|
                d.source_file()
 | 
						|
                    .unwrap_or_else(|| panic!("{path:?}: Error without a source file {d:?}",)),
 | 
						|
            ) == path
 | 
						|
        })
 | 
						|
        .collect::<Vec<_>>();
 | 
						|
 | 
						|
    let lines = source
 | 
						|
        .bytes()
 | 
						|
        .enumerate()
 | 
						|
        .filter_map(|(i, c)| if c == b'\n' { Some(i) } else { None })
 | 
						|
        .collect::<Vec<usize>>();
 | 
						|
 | 
						|
    // Find expected errors in the file. The first caret (^) points to the expected column. The number of
 | 
						|
    // carets refers to the number of lines to go back. This is useful when one line of code produces multiple
 | 
						|
    // errors or warnings.
 | 
						|
    let re = regex::Regex::new(r"\n *//[^\n\^]*(\^+)(error|warning)\{([^\n]*)\}").unwrap();
 | 
						|
    for m in re.captures_iter(source) {
 | 
						|
        let line_begin_offset = m.get(0).unwrap().start();
 | 
						|
        let column = m.get(1).unwrap().start() - line_begin_offset;
 | 
						|
        let lines_to_source = m.get(1).unwrap().as_str().len();
 | 
						|
        let warning_or_error = m.get(2).unwrap().as_str();
 | 
						|
        let rx = m.get(3).unwrap().as_str();
 | 
						|
        let r = match regex::Regex::new(rx) {
 | 
						|
            Err(e) => {
 | 
						|
                eprintln!("{path:?}: Invalid regexp {rx:?} : {e:?}");
 | 
						|
                return Ok(false);
 | 
						|
            }
 | 
						|
            Ok(r) => r,
 | 
						|
        };
 | 
						|
 | 
						|
        let mut line_counter = 0;
 | 
						|
        let mut line_offset = source[..line_begin_offset].rfind('\n').unwrap_or(0);
 | 
						|
        let offset = loop {
 | 
						|
            line_counter += 1;
 | 
						|
            if line_counter >= lines_to_source {
 | 
						|
                break line_offset + column;
 | 
						|
            }
 | 
						|
            if let Some(o) = source[..line_offset].rfind('\n') {
 | 
						|
                line_offset = o;
 | 
						|
            } else {
 | 
						|
                break 1;
 | 
						|
            };
 | 
						|
        };
 | 
						|
 | 
						|
        let expected_diag_level = match warning_or_error {
 | 
						|
            "warning" => i_slint_compiler::diagnostics::DiagnosticLevel::Warning,
 | 
						|
            "error" => i_slint_compiler::diagnostics::DiagnosticLevel::Error,
 | 
						|
            _ => panic!("Unsupported diagnostic level {warning_or_error}"),
 | 
						|
        };
 | 
						|
 | 
						|
        match diags.iter().position(|e| {
 | 
						|
            let (l, c) = e.line_column();
 | 
						|
            let o = lines.get(l.wrapping_sub(2)).unwrap_or(&0) + c;
 | 
						|
            o == offset && r.is_match(e.message()) && e.level() == expected_diag_level
 | 
						|
        }) {
 | 
						|
            Some(idx) => {
 | 
						|
                diags.remove(idx);
 | 
						|
            }
 | 
						|
            None => {
 | 
						|
                success = false;
 | 
						|
                println!("{path:?}: {warning_or_error} not found at offset {offset}: {rx:?}");
 | 
						|
            }
 | 
						|
        }
 | 
						|
    }
 | 
						|
 | 
						|
    // Ignore deprecated warning about old syntax, because our tests still use the old syntax a lot
 | 
						|
    diags.retain(|d| !(d.message().contains("':='") && d.message().contains("deprecated")));
 | 
						|
 | 
						|
    if !diags.is_empty() {
 | 
						|
        println!("{path:?}: Unexpected errors/warnings: {diags:#?}");
 | 
						|
 | 
						|
        #[cfg(feature = "display-diagnostics")]
 | 
						|
        if !_silent {
 | 
						|
            let mut to_report = i_slint_compiler::diagnostics::BuildDiagnostics::default();
 | 
						|
            for d in diags {
 | 
						|
                to_report.push_compiler_error(d.clone());
 | 
						|
            }
 | 
						|
            to_report.print();
 | 
						|
        }
 | 
						|
 | 
						|
        success = false;
 | 
						|
    }
 | 
						|
    Ok(success)
 | 
						|
}
 | 
						|
 | 
						|
fn canonical(path: &Path) -> PathBuf {
 | 
						|
    path.canonicalize().unwrap_or_else(|_| path.to_owned())
 | 
						|
}
 | 
						|
 | 
						|
fn process_file_source(
 | 
						|
    path: &std::path::Path,
 | 
						|
    source: String,
 | 
						|
    silent: bool,
 | 
						|
) -> std::io::Result<bool> {
 | 
						|
    let mut parse_diagnostics = i_slint_compiler::diagnostics::BuildDiagnostics::default();
 | 
						|
    let syntax_node =
 | 
						|
        i_slint_compiler::parser::parse(source.clone(), Some(path), &mut parse_diagnostics);
 | 
						|
 | 
						|
    let has_parse_error = parse_diagnostics.has_errors();
 | 
						|
    let mut compiler_config = i_slint_compiler::CompilerConfiguration::new(
 | 
						|
        i_slint_compiler::generator::OutputFormat::Interpreter,
 | 
						|
    );
 | 
						|
    compiler_config.embed_resources = i_slint_compiler::EmbedResourcesKind::OnlyBuiltinResources;
 | 
						|
    compiler_config.enable_experimental = true;
 | 
						|
    compiler_config.style = Some("fluent".into());
 | 
						|
    compiler_config.components_to_generate =
 | 
						|
        if source.contains("config:generate_all_exported_windows") {
 | 
						|
            ComponentSelection::ExportedWindows
 | 
						|
        } else {
 | 
						|
            // Otherwise we'd have lots of warnings about not inheriting Window
 | 
						|
            ComponentSelection::LastExported
 | 
						|
        };
 | 
						|
    let compile_diagnostics = if !parse_diagnostics.has_errors() {
 | 
						|
        let (_, build_diags, _) = spin_on::spin_on(i_slint_compiler::compile_syntax_node(
 | 
						|
            syntax_node.clone(),
 | 
						|
            parse_diagnostics,
 | 
						|
            compiler_config.clone(),
 | 
						|
        ));
 | 
						|
        build_diags
 | 
						|
    } else {
 | 
						|
        parse_diagnostics
 | 
						|
    };
 | 
						|
 | 
						|
    let mut success = true;
 | 
						|
    success &= process_diagnostics(&compile_diagnostics, path, &source, silent)?;
 | 
						|
 | 
						|
    for p in &compile_diagnostics.all_loaded_files {
 | 
						|
        let source = if p.is_absolute() {
 | 
						|
            std::fs::read_to_string(p)?
 | 
						|
        } else {
 | 
						|
            // probably std-widgets.slint
 | 
						|
            String::new()
 | 
						|
        };
 | 
						|
        success &= process_diagnostics(&compile_diagnostics, p, &source, silent)?;
 | 
						|
    }
 | 
						|
 | 
						|
    if has_parse_error {
 | 
						|
        // Still try to compile to make sure it doesn't panic
 | 
						|
        spin_on::spin_on(i_slint_compiler::compile_syntax_node(
 | 
						|
            syntax_node,
 | 
						|
            compile_diagnostics,
 | 
						|
            compiler_config,
 | 
						|
        ));
 | 
						|
    }
 | 
						|
 | 
						|
    Ok(success)
 | 
						|
}
 | 
						|
 | 
						|
#[test]
 | 
						|
/// Test that this actually fail when it should
 | 
						|
fn self_test() -> std::io::Result<()> {
 | 
						|
    let fake_path = std::path::Path::new("fake.slint");
 | 
						|
    let process = |str: &str| process_file_source(fake_path, str.into(), true);
 | 
						|
 | 
						|
    // this should succeed
 | 
						|
    assert!(process(
 | 
						|
        r#"
 | 
						|
export Foo := Rectangle { x: 0px; }
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // unless we expected an error
 | 
						|
    assert!(!process(
 | 
						|
        r#"
 | 
						|
export Foo := Rectangle { x: 0px; }
 | 
						|
//            ^error{i want an error}
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // An error should fail
 | 
						|
    assert!(!process(
 | 
						|
        r#"
 | 
						|
export Foo := Rectangle foo { x:0px; }
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // An error with the proper comment should pass
 | 
						|
    assert!(process(
 | 
						|
        r#"
 | 
						|
Foo := Rectangle foo { x:0px; }
 | 
						|
//               ^error{expected '\{'}
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // But not if it is at the wrong position
 | 
						|
    assert!(!process(
 | 
						|
        r#"
 | 
						|
Foo := Rectangle foo { x:0px; }
 | 
						|
//             ^error{expected '\{'}
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // or the wrong line
 | 
						|
    assert!(!process(
 | 
						|
        r#"
 | 
						|
Foo := Rectangle foo { x:0px; }
 | 
						|
 | 
						|
//               ^error{expected '\{'}
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // or the wrong message
 | 
						|
    assert!(!process(
 | 
						|
        r#"
 | 
						|
Foo := Rectangle foo { x:0px; }
 | 
						|
//               ^error{foo_bar}
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // or the wrong line because two carets
 | 
						|
    assert!(!process(
 | 
						|
        r#"
 | 
						|
 | 
						|
Foo := Rectangle foo { x:0px; }
 | 
						|
//               ^^error{expected '\{'}
 | 
						|
    "#
 | 
						|
    )?);
 | 
						|
 | 
						|
    // Even on windows, it should work
 | 
						|
    assert!(process(
 | 
						|
        "\r\nFoo := Rectangle foo { x:0px; }\r\n//               ^error{expected '\\{'}\r\n"
 | 
						|
    )?);
 | 
						|
 | 
						|
    Ok(())
 | 
						|
}
 |