slint/internal/backends/winit/glcontext.rs
Simon Hausmann ea73253d16 Fix panic in online editor when resizing the preview widget
A resize of the HTML canvas element would trigger our own resize
handler, which tried to do a special dance to trigger a redraw.

As it turns out, this breaks with current winit as the event loop target
is gone, so calling with_window_target() panics.

See also commit 8b728df021

Instead, this patch reverts to the simpler method of calling
invoke_from_event_loop, has workarounds for how to properly wake up the
event loop and return poll. In there we can just call request_redraw()
on the winit window directly to trigger a draw.
2022-09-20 10:12:39 +02:00

295 lines
12 KiB
Rust

// Copyright © SixtyFPS GmbH <info@slint-ui.com>
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-commercial
use std::cell::RefCell;
#[cfg(target_arch = "wasm32")]
use std::rc::Rc;
// glutin::WindowedContext tries to enforce being current or not. Since we need the WindowedContext's window() function
// in the GL renderer regardless whether we're current or not, we wrap the two states back into one type.
enum OpenGLContextState {
#[cfg(not(target_arch = "wasm32"))]
NotCurrent(glutin::WindowedContext<glutin::NotCurrent>),
#[cfg(not(target_arch = "wasm32"))]
Current(glutin::WindowedContext<glutin::PossiblyCurrent>),
#[cfg(target_arch = "wasm32")]
Current { window: Rc<winit::window::Window>, canvas: web_sys::HtmlCanvasElement },
}
pub struct OpenGLContext(RefCell<Option<OpenGLContextState>>);
impl OpenGLContext {
pub fn window(&self) -> std::cell::Ref<winit::window::Window> {
std::cell::Ref::map(self.0.borrow(), |state| match state.as_ref().unwrap() {
#[cfg(not(target_arch = "wasm32"))]
OpenGLContextState::NotCurrent(context) => context.window(),
#[cfg(not(target_arch = "wasm32"))]
OpenGLContextState::Current(context) => context.window(),
#[cfg(target_arch = "wasm32")]
OpenGLContextState::Current { window, .. } => window.as_ref(),
})
}
#[cfg(target_arch = "wasm32")]
pub fn html_canvas_element(&self) -> std::cell::Ref<web_sys::HtmlCanvasElement> {
std::cell::Ref::map(self.0.borrow(), |state| match state.as_ref().unwrap() {
OpenGLContextState::Current { canvas, .. } => canvas,
})
}
#[cfg(skia_backend_opengl)]
pub fn glutin_context(
&self,
) -> std::cell::Ref<glutin::WindowedContext<glutin::PossiblyCurrent>> {
std::cell::Ref::map(self.0.borrow(), |state| match state.as_ref().unwrap() {
OpenGLContextState::Current(gl_context) => gl_context,
OpenGLContextState::NotCurrent(..) => {
panic!("internal error: glutin_context() called without current context")
}
})
}
pub fn make_current(&self) {
let mut ctx = self.0.borrow_mut();
*ctx = Some(match ctx.take().unwrap() {
#[cfg(not(target_arch = "wasm32"))]
OpenGLContextState::NotCurrent(not_current_ctx) => {
let current_ctx = unsafe { not_current_ctx.make_current().unwrap() };
OpenGLContextState::Current(current_ctx)
}
state @ OpenGLContextState::Current { .. } => state,
});
}
pub fn make_not_current(&self) {
#[cfg(not(target_arch = "wasm32"))]
{
let mut ctx = self.0.borrow_mut();
*ctx = Some(match ctx.take().unwrap() {
state @ OpenGLContextState::NotCurrent(_) => state,
OpenGLContextState::Current(current_ctx_rc) => {
OpenGLContextState::NotCurrent(unsafe {
current_ctx_rc.make_not_current().unwrap()
})
}
});
}
}
#[cfg(any(feature = "renderer-winit-femtovg", enable_skia_renderer))]
pub fn with_current_context<T>(&self, cb: impl FnOnce(&Self) -> T) -> T {
if matches!(self.0.borrow().as_ref().unwrap(), OpenGLContextState::Current { .. }) {
cb(self)
} else {
self.make_current();
let result = cb(self);
self.make_not_current();
result
}
}
pub fn swap_buffers(&self) {
#[cfg(not(target_arch = "wasm32"))]
match &self.0.borrow().as_ref().unwrap() {
OpenGLContextState::NotCurrent(_) => {}
OpenGLContextState::Current(current_ctx) => {
current_ctx.swap_buffers().unwrap();
}
}
}
pub fn ensure_resized(&self) {
#[cfg(not(target_arch = "wasm32"))]
{
let mut ctx = self.0.borrow_mut();
*ctx = Some(match ctx.take().unwrap() {
#[cfg(not(target_arch = "wasm32"))]
OpenGLContextState::NotCurrent(not_current_ctx) => {
let current_ctx = unsafe { not_current_ctx.make_current().unwrap() };
current_ctx.resize(current_ctx.window().inner_size());
OpenGLContextState::NotCurrent(unsafe {
current_ctx.make_not_current().unwrap()
})
}
OpenGLContextState::Current(current) => {
current.resize(current.window().inner_size());
OpenGLContextState::Current(current)
}
});
}
}
pub fn new_context(
window_builder: winit::window::WindowBuilder,
#[cfg(target_arch = "wasm32")] canvas_id: &str,
) -> Self {
#[cfg(not(target_arch = "wasm32"))]
{
use crate::event_loop::EventLoopInterface;
use glutin::ContextBuilder;
let windowed_context = crate::event_loop::with_window_target(|event_loop| {
// Try different strategies for creating an GL context. First request our "favorite", OpenGL ES 2.0,
// then try GlLatest (but with windows quirk) and finally try glutin's defaults.
// We might be able to just go back to requesting GlLatest if
// https://github.com/rust-windowing/glutin/issues/1371 is resolved
// in favor of falling back to creating a GLES context.
let context_factory_fns = [
|window_builder, event_loop: &dyn EventLoopInterface| {
let builder = ContextBuilder::new()
.with_vsync(true)
.with_gl(glutin::GlRequest::Specific(glutin::Api::OpenGlEs, (2, 0)));
#[cfg(target_os = "windows")]
let builder = builder.with_srgb(false);
builder
.build_windowed(window_builder, event_loop.event_loop_target())
.map_err(|creation_error| {
format!(
"could not create OpenGL ES 2.0 context: {}",
creation_error
)
})
},
|window_builder, event_loop: &dyn EventLoopInterface| {
let builder = ContextBuilder::new().with_vsync(true);
// With latest Windows 10 and VmWare glutin's default for srgb produces surfaces that are always rendered black :(
#[cfg(target_os = "windows")]
let builder = builder.with_srgb(false);
builder
.build_windowed(window_builder, event_loop.event_loop_target())
.map_err(|creation_error| {
format!(
"could not create GlLatest context (with windows quirk): {}",
creation_error
)
})
},
|window_builder, event_loop: &dyn EventLoopInterface| {
// Try again with glutin defaults
ContextBuilder::new()
.with_vsync(true)
.build_windowed(window_builder, event_loop.event_loop_target())
.map_err(|creation_error| {
format!("could not create GlLatest context : {}", creation_error)
})
},
];
let mut last_err = None;
for factory_fn in context_factory_fns {
match factory_fn(window_builder.clone(), event_loop) {
Ok(new_context) => {
return new_context;
}
Err(e) => {
last_err = Some(e);
}
}
}
panic!("Failed to create OpenGL context: {}", last_err.unwrap())
});
let windowed_context = unsafe { windowed_context.make_current().unwrap() };
#[cfg(target_os = "macos")]
{
use cocoa::appkit::NSView;
use winit::platform::macos::WindowExtMacOS;
let ns_view = windowed_context.window().ns_view();
let view_id: cocoa::base::id = ns_view as *const _ as *mut _;
unsafe {
NSView::setLayerContentsPlacement(view_id, cocoa::appkit::NSViewLayerContentsPlacement::NSViewLayerContentsPlacementTopLeft)
}
}
Self(RefCell::new(Some(OpenGLContextState::Current(windowed_context))))
}
#[cfg(target_arch = "wasm32")]
{
use wasm_bindgen::JsCast;
let canvas = web_sys::window()
.unwrap()
.document()
.unwrap()
.get_element_by_id(canvas_id)
.unwrap()
.dyn_into::<web_sys::HtmlCanvasElement>()
.unwrap();
use winit::platform::web::WindowBuilderExtWebSys;
let existing_canvas_size = winit::dpi::LogicalSize::new(
canvas.client_width() as u32,
canvas.client_height() as u32,
);
let window = Rc::new(crate::event_loop::with_window_target(|event_loop| {
window_builder
.with_canvas(Some(canvas.clone()))
.build(&event_loop.event_loop_target())
.unwrap()
}));
// Try to maintain the existing size of the canvas element. A window created with winit
// on the web will always have 1024x768 as size otherwise.
let resize_canvas = {
let window = window.clone();
let canvas = canvas.clone();
move |_: web_sys::Event| {
let existing_canvas_size = winit::dpi::LogicalSize::new(
canvas.client_width() as u32,
canvas.client_height() as u32,
);
window.set_inner_size(existing_canvas_size);
let winit_window_weak = send_wrapper::SendWrapper::new(Rc::downgrade(&window));
i_slint_core::api::invoke_from_event_loop(move || {
if let Some(winit_window) = winit_window_weak.take().upgrade() {
winit_window.request_redraw();
}
})
.unwrap();
}
};
let resize_closure =
wasm_bindgen::closure::Closure::wrap(Box::new(resize_canvas) as Box<dyn FnMut(_)>);
web_sys::window()
.unwrap()
.add_event_listener_with_callback("resize", resize_closure.as_ref().unchecked_ref())
.unwrap();
resize_closure.forget();
{
let default_size = window.inner_size().to_logical(window.scale_factor());
let new_size = winit::dpi::LogicalSize::new(
if existing_canvas_size.width > 0 {
existing_canvas_size.width
} else {
default_size.width
},
if existing_canvas_size.height > 0 {
existing_canvas_size.height
} else {
default_size.height
},
);
if new_size != default_size {
window.set_inner_size(new_size);
}
}
Self(RefCell::new(Some(OpenGLContextState::Current { window, canvas })))
}
}
#[cfg(not(target_arch = "wasm32"))]
pub fn get_proc_address(&self, name: &str) -> *const std::ffi::c_void {
match &self.0.borrow().as_ref().unwrap() {
OpenGLContextState::NotCurrent(_) => std::ptr::null(),
OpenGLContextState::Current(current_ctx) => current_ctx.get_proc_address(name),
}
}
}