slint/sixtyfps_compiler/passes/check_expressions.rs
Olivier Goffart 80d7b2ebe8 Hard error when not calling a callback
While before it was silently ignored or caused error in the generated code.

Fixes #542
2021-10-05 12:56:26 +02:00

42 lines
1.7 KiB
Rust

/* LICENSE BEGIN
This file is part of the SixtyFPS Project -- https://sixtyfps.io
Copyright (c) 2021 Olivier Goffart <olivier.goffart@sixtyfps.io>
Copyright (c) 2021 Simon Hausmann <simon.hausmann@sixtyfps.io>
SPDX-License-Identifier: GPL-3.0-only
This file is also available under commercial licensing terms.
Please contact info@sixtyfps.io for more information.
LICENSE END */
use std::rc::Rc;
use crate::diagnostics::BuildDiagnostics;
use crate::expression_tree::{BuiltinFunction, Expression};
use crate::object_tree::{visit_all_expressions, Component};
/// Check the validity of expressions
///
/// - Make sure that there is no uncalled member function or macro
pub fn check_expressions(doc: &crate::object_tree::Document, diag: &mut BuildDiagnostics) {
for component in &doc.inner_components {
visit_all_expressions(component, |e, _| check_expression(component, e, diag));
}
}
fn check_expression(component: &Rc<Component>, e: &Expression, diag: &mut BuildDiagnostics) {
match e {
Expression::MemberFunction { .. } => {
// Must already have been be reported.
debug_assert!(diag.has_error());
}
Expression::BuiltinMacroReference(_, node) => {
diag.push_error("Builtin function must be called".into(), node);
}
Expression::BuiltinFunctionReference(BuiltinFunction::GetWindowScaleFactor, loc) => {
if component.is_global() {
diag.push_error("Cannot convert between logical and physical length in a global component, because the scale factor is not known".into(), loc);
}
}
_ => e.visit(|e| check_expression(component, e, diag)),
}
}