slint/internal/compiler/passes/clip.rs
Milian Wolff f6da161dbb
Reduce SmolStr <-> &str conversions and copies (#6688)
SmolStr has an Arc internally for large strings. This allows
cheap copies of large strings, but we lose that ability
when we convert the SmolStr to a &str and then reconstruct a
SmolStr from that slice.

I was hoping for some larger gains here, considering the impact
of this code change, but it only removes ~50k allocations,
while the impact on the runtime is not noticeable at all.

Still, I believe this is the right thing to do.

Before:
```
        allocations:            2338981

  Time (mean ± σ):     988.3 ms ±  17.9 ms    [User: 690.2 ms, System: 206.4 ms]
  Range (min … max):   956.4 ms … 1016.3 ms    10 runs
```

After:
```
        allocations:            2287723

  Time (mean ± σ):     989.8 ms ±  23.2 ms    [User: 699.2 ms, System: 197.6 ms]
  Range (min … max):   945.3 ms … 1021.4 ms    10 runs
```
2024-11-19 10:07:16 +01:00

137 lines
4.8 KiB
Rust

// Copyright © SixtyFPS GmbH <info@slint.dev>
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
//! Pass that lowers synthetic `clip` properties to Clip element
use smol_str::{format_smolstr, SmolStr};
use std::cell::RefCell;
use std::rc::Rc;
use crate::diagnostics::{BuildDiagnostics, Spanned};
use crate::expression_tree::{BindingExpression, Expression, NamedReference};
use crate::langtype::NativeClass;
use crate::object_tree::{Component, Element, ElementRc};
use crate::typeregister::TypeRegister;
pub fn handle_clip(
component: &Rc<Component>,
type_register: &TypeRegister,
diag: &mut BuildDiagnostics,
) {
let native_clip =
type_register.lookup_builtin_element("Clip").unwrap().as_builtin().native_class.clone();
crate::object_tree::recurse_elem_including_sub_components(
component,
&(),
&mut |elem_rc: &ElementRc, _| {
let elem = elem_rc.borrow();
if elem.native_class().map_or(false, |n| Rc::ptr_eq(&n, &native_clip)) {
return;
}
if elem.bindings.contains_key("clip")
|| elem
.property_analysis
.borrow()
.get("clip")
.map_or(false, |a| a.is_set || a.is_linked)
{
match elem.builtin_type().as_ref().map(|ty| ty.name.as_str()) {
Some("Rectangle") => {}
Some("Path") => {
// it's an actual property, so keep it as is
return;
}
_ => {
diag.push_error(
"The 'clip' property can only be applied to a Rectangle or a Path for now".into(),
&elem.bindings.get("clip").and_then(|x| x.borrow().span.clone()).unwrap_or_else(|| elem.to_source_location()),
);
return;
}
}
drop(elem);
create_clip_element(elem_rc, &native_clip);
}
},
);
}
fn create_clip_element(parent_elem: &ElementRc, native_clip: &Rc<NativeClass>) {
let mut parent = parent_elem.borrow_mut();
let clip = Element::make_rc(Element {
id: format_smolstr!("{}-clip", parent.id),
base_type: crate::langtype::ElementType::Native(native_clip.clone()),
children: std::mem::take(&mut parent.children),
enclosing_component: parent.enclosing_component.clone(),
..Element::default()
});
parent.children.push(clip.clone());
drop(parent); // NamedReference::new will borrow() the parent, so we can't hold a mutable ref
clip.borrow_mut().bindings = ["width", "height"]
.iter()
.map(|prop| {
(
SmolStr::new_static(prop),
RefCell::new(
Expression::PropertyReference(NamedReference::new(
parent_elem,
SmolStr::new_static(prop),
))
.into(),
),
)
})
.collect();
copy_optional_binding(parent_elem, "border-width", &clip);
if super::border_radius::BORDER_RADIUS_PROPERTIES
.iter()
.any(|property_name| parent_elem.borrow().is_binding_set(property_name, true))
{
for optional_binding in super::border_radius::BORDER_RADIUS_PROPERTIES.iter() {
copy_optional_binding(parent_elem, optional_binding, &clip);
}
} else if parent_elem.borrow().bindings.contains_key("border-radius") {
for prop in super::border_radius::BORDER_RADIUS_PROPERTIES.iter() {
clip.borrow_mut().bindings.insert(
SmolStr::new(prop),
RefCell::new(
Expression::PropertyReference(NamedReference::new(
parent_elem,
SmolStr::new_static("border-radius"),
))
.into(),
),
);
}
}
clip.borrow_mut().bindings.insert(
SmolStr::new_static("clip"),
BindingExpression::new_two_way(NamedReference::new(
parent_elem,
SmolStr::new_static("clip"),
))
.into(),
);
}
fn copy_optional_binding(
parent_elem: &ElementRc,
optional_binding: &'static str,
clip: &ElementRc,
) {
if parent_elem.borrow().bindings.contains_key(optional_binding) {
clip.borrow_mut().bindings.insert(
optional_binding.into(),
RefCell::new(
Expression::PropertyReference(NamedReference::new(
parent_elem,
SmolStr::new_static(optional_binding),
))
.into(),
),
);
}
}