mirror of
https://github.com/slint-ui/slint.git
synced 2025-09-09 20:06:18 +00:00
f6da161dbb
SmolStr has an Arc internally for large strings. This allows
cheap copies of large strings, but we lose that ability
when we convert the SmolStr to a &str and then reconstruct a
SmolStr from that slice.
I was hoping for some larger gains here, considering the impact
of this code change, but it only removes ~50k allocations,
while the impact on the runtime is not noticeable at all.
Still, I believe this is the right thing to do.
Before:
```
allocations: 2338981
Time (mean ± σ): 988.3 ms ± 17.9 ms [User: 690.2 ms, System: 206.4 ms]
Range (min … max): 956.4 ms … 1016.3 ms 10 runs
```
After:
```
allocations: 2287723
Time (mean ± σ): 989.8 ms ± 23.2 ms [User: 699.2 ms, System: 197.6 ms]
Range (min … max): 945.3 ms … 1021.4 ms 10 runs
```
77 lines
3 KiB
Rust
77 lines
3 KiB
Rust
// Copyright © SixtyFPS GmbH <info@slint.dev>
|
|
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
|
|
|
|
//! Passe that transform the Timer element into a timer in the Component
|
|
|
|
use crate::diagnostics::BuildDiagnostics;
|
|
use crate::expression_tree::{BuiltinFunction, Expression, NamedReference};
|
|
use crate::langtype::ElementType;
|
|
use crate::object_tree::*;
|
|
use smol_str::SmolStr;
|
|
use std::rc::Rc;
|
|
|
|
pub fn lower_timers(component: &Rc<Component>, diag: &mut BuildDiagnostics) {
|
|
recurse_elem_including_sub_components_no_borrow(
|
|
component,
|
|
&None,
|
|
&mut |elem, parent_element: &Option<ElementRc>| {
|
|
let is_timer = matches!(&elem.borrow().base_type, ElementType::Builtin(base_type) if base_type.name == "Timer");
|
|
if is_timer {
|
|
lower_timer(elem, parent_element.as_ref(), diag);
|
|
}
|
|
Some(elem.clone())
|
|
},
|
|
)
|
|
}
|
|
|
|
fn lower_timer(
|
|
timer_element: &ElementRc,
|
|
parent_element: Option<&ElementRc>,
|
|
diag: &mut BuildDiagnostics,
|
|
) {
|
|
let parent_component = timer_element.borrow().enclosing_component.upgrade().unwrap();
|
|
let Some(parent_element) = parent_element else {
|
|
diag.push_error("A component cannot inherit from Timer".into(), &*timer_element.borrow());
|
|
return;
|
|
};
|
|
|
|
if Rc::ptr_eq(&parent_component.root_element, timer_element) {
|
|
diag.push_error(
|
|
"Timer cannot be directly repeated or conditional".into(),
|
|
&*timer_element.borrow(),
|
|
);
|
|
return;
|
|
}
|
|
|
|
if !timer_element.borrow().is_binding_set("interval", true) {
|
|
diag.push_error(
|
|
"Timer must have a binding set for its 'interval' property".into(),
|
|
&*timer_element.borrow(),
|
|
);
|
|
return;
|
|
}
|
|
|
|
// Remove the timer_element from its parent
|
|
let old_size = parent_element.borrow().children.len();
|
|
parent_element.borrow_mut().children.retain(|child| !Rc::ptr_eq(child, timer_element));
|
|
debug_assert_eq!(
|
|
parent_element.borrow().children.len() + 1,
|
|
old_size,
|
|
"Exactly one child must be removed (the timer itself)"
|
|
);
|
|
parent_component.optimized_elements.borrow_mut().push(timer_element.clone());
|
|
|
|
parent_component.timers.borrow_mut().push(Timer {
|
|
interval: NamedReference::new(timer_element, SmolStr::new_static("interval")),
|
|
running: NamedReference::new(timer_element, SmolStr::new_static("running")),
|
|
triggered: NamedReference::new(timer_element, SmolStr::new_static("triggered")),
|
|
});
|
|
let update_timers = Expression::FunctionCall {
|
|
function: Expression::BuiltinFunctionReference(BuiltinFunction::UpdateTimers, None).into(),
|
|
arguments: vec![],
|
|
source_location: None,
|
|
};
|
|
let change_callbacks = &mut timer_element.borrow_mut().change_callbacks;
|
|
change_callbacks.entry("running".into()).or_default().borrow_mut().push(update_timers.clone());
|
|
change_callbacks.entry("interval".into()).or_default().borrow_mut().push(update_timers);
|
|
}
|