language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-11-25 05:22:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: emit latest status and artifact with correct signals (#1294) (#1330)

Browse source 
* fix: emit latest compiled artifact with correct signals

* fix: bad guard
This commit is contained in:
Myriad-Dreamin 2025-02-19 22:34:11 +08:00 • committed by GitHub
parent 26fd50febf
commit 0c64bea89e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 125 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

43
crates/tinymist-project/src/compiler.rs
View file

@ -127,20 +127,12 @@ impl<F: CompilerFeat> CompiledArtifact<F> {
pub enum CompileReport {
Suspend,
Stage(FileId, &'static str, tinymist_std::time::Time),
CompileError(
FileId,
EcoVec<SourceDiagnostic>,
tinymist_std::time::Duration,
),
ExportError(
FileId,
EcoVec<SourceDiagnostic>,
tinymist_std::time::Duration,
),
CompileError(FileId, usize, tinymist_std::time::Duration),
ExportError(FileId, usize, tinymist_std::time::Duration),
CompileSuccess(
FileId,
// warnings, if not empty
EcoVec<SourceDiagnostic>,
usize,
tinymist_std::time::Duration,
),
}
@ -166,7 +158,7 @@ impl CompileReport {
}
}
pub fn diagnostics(self) -> Option<EcoVec<SourceDiagnostic>> {
pub fn diagnostics_size(self) -> Option<usize> {
match self {
Self::Suspend | Self::Stage(..) => None,
Self::CompileError(_, diagnostics, ..)
@ -193,13 +185,12 @@ impl fmt::Display for CompileReportMsg<'_> {
Suspend => write!(f, "suspended"),
Stage(_, stage, ..) => write!(f, "{input:?}: {stage} ..."),
CompileSuccess(_, warnings, duration) => {
if warnings.is_empty() {
if *warnings == 0 {
write!(f, "{input:?}: compilation succeeded in {duration:?}")
} else {
write!(
f,
"{input:?}: compilation succeeded with {} warnings in {duration:?}",
warnings.len()
"{input:?}: compilation succeeded with {warnings} warnings in {duration:?}",
)
}
}
@ -217,7 +208,7 @@ pub trait CompileHandler<F: CompilerFeat, Ext>: Send + Sync + 'static {
fn on_any_compile_reason(&self, state: &mut ProjectCompiler<F, Ext>);
// todo: notify project specific compile
/// Called when a compilation is done.
fn notify_compile(&self, res: &CompiledArtifact<F>, rep: CompileReport);
fn notify_compile(&self, res: &CompiledArtifact<F>);
/// Called when a project is removed.
fn notify_removed(&self, _id: &ProjectInsId) {}
/// Called when the compilation status is changed.
@ -231,7 +222,7 @@ impl<F: CompilerFeat + Send + Sync + 'static, Ext: 'static> CompileHandler<F, Ex
fn on_any_compile_reason(&self, _state: &mut ProjectCompiler<F, Ext>) {
log::info!("ProjectHandle: no need to compile");
}
fn notify_compile(&self, _res: &CompiledArtifact<F>, _rep: CompileReport) {}
fn notify_compile(&self, _res: &CompiledArtifact<F>) {}
fn status(&self, _revision: usize, _id: &ProjectInsId, _rep: CompileReport) {}
}
@ -280,6 +271,16 @@ pub struct CompileReasons {
pub by_entry_update: bool,
}
impl From<CompileReasons> for ExportSignal {
fn from(value: CompileReasons) -> Self {
Self {
by_mem_events: value.by_memory_events,
by_fs_events: value.by_fs_events,
by_entry_update: value.by_entry_update,
}
}
}
impl CompileReasons {
/// Merge two reasons.
pub fn see(&mut self, reason: CompileReasons) {
@ -795,13 +796,15 @@ impl<F: CompilerFeat, Ext: 'static> ProjectInsState<F, Ext> {
let elapsed = start.elapsed().unwrap_or_default();
let rep = match &compiled.doc {
Ok(..) => CompileReport::CompileSuccess(id, compiled.warnings.clone(), elapsed),
Err(err) => CompileReport::CompileError(id, err.clone(), elapsed),
Ok(..) => CompileReport::CompileSuccess(id, compiled.warnings.len(), elapsed),
Err(err) => CompileReport::CompileError(id, err.len(), elapsed),
};
// todo: we need to check revision for really concurrent compilation
log_compile_report(&rep);
h.notify_compile(&compiled, rep);
h.status(revision, &compiled.id, rep);
h.notify_compile(&compiled);
compiled
}