language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-07-24 05:05:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

feat: generate names for destructuring closure params (#319)

Browse source
This commit is contained in:
Lars Wrenger 2024-05-31 06:24:08 +02:00 • committed by GitHub
parent 10b0fd7ea3
commit 257a6bcb86
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 44 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

66
crates/tinymist-query/src/analysis/signature.rs
View file

@ -418,31 +418,11 @@ fn analyze_closure_signature(c: Arc<LazyHash<Closure>>) -> Vec<Arc<ParamSpec>> {
for param in closure_ast.params().children() {
match param {
ast::Param::Pos(ast::Pattern::Placeholder(..)) => {
params.push(Arc::new(ParamSpec {
name: "_".into(),
input: CastInfo::Any,
base_type: None,
type_repr: None,
expr: None,
default: None,
positional: true,
named: false,
variadic: false,
settable: false,
docs: Cow::Borrowed(""),
}));
}
ast::Param::Pos(e) => {
// todo: destructing
let name = e.bindings();
if name.len() != 1 {
continue;
}
let name = name[0].as_str();
let name = format!("{}", PatternDisplay(&e));
params.push(Arc::new(ParamSpec {
name: name.into(),
name: name.as_str().into(),
input: CastInfo::Any,
base_type: None,
type_repr: None,
@ -494,6 +474,48 @@ fn analyze_closure_signature(c: Arc<LazyHash<Closure>>) -> Vec<Arc<ParamSpec>> {
params
}
struct PatternDisplay<'a>(&'a ast::Pattern<'a>);
impl<'a> fmt::Display for PatternDisplay<'a> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self.0 {
ast::Pattern::Normal(ast::Expr::Ident(ident)) => f.write_str(ident.as_str()),
ast::Pattern::Normal(_) => f.write_str("?"), // unreachable?
ast::Pattern::Placeholder(_) => f.write_str("_"),
ast::Pattern::Parenthesized(p) => {
write!(f, "{}", PatternDisplay(&p.pattern()))
}
ast::Pattern::Destructuring(d) => {
write!(f, "(")?;
let mut first = true;
for item in d.items() {
if first {
first = false;
} else {
write!(f, ", ")?;
}
match item {
ast::DestructuringItem::Pattern(p) => write!(f, "{}", PatternDisplay(&p))?,
ast::DestructuringItem::Named(n) => write!(
f,
"{}: {}",
n.name().as_str(),
unwrap_expr(n.expr()).to_untyped().text()
)?,
ast::DestructuringItem::Spread(s) => write!(
f,
"..{}",
s.sink_ident().map(|i| i.as_str()).unwrap_or_default()
)?,
}
}
write!(f, ")")?;
Ok(())
}
}
}
}
fn unwrap_expr(mut e: ast::Expr) -> ast::Expr {
while let ast::Expr::Parenthesized(p) = e {
e = p.expr();