language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-07-22 20:25:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: don't trigger trivial completion when the trigger char is an ascii punctuation (#748)

Browse source
This commit is contained in:
Myriad-Dreamin 2024-10-29 22:32:12 +08:00 • committed by GitHub
parent e8f5f6185a
commit 493f8a8695
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 162 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/tinymist-query/src/completion.rs
View file

@ -46,6 +46,8 @@ pub struct CompletionRequest {
pub position: LspPosition,
/// Whether the completion is triggered explicitly.
pub explicit: bool,
/// The character that triggered the completion, if any.
pub trigger_character: Option<char>,
/// Whether to trigger suggest completion, a.k.a. auto-completion.
pub trigger_suggest: bool,
/// Whether to trigger named parameter completion.
@ -145,6 +147,7 @@ impl StatefulRequest for CompletionRequest {
&source,
cursor,
explicit,
self.trigger_character,
self.trigger_suggest,
self.trigger_parameter_hints,
self.trigger_named_completion,
@ -336,6 +339,11 @@ mod tests {
let docs = find_module_level_docs(&source).unwrap_or_default();
let properties = get_test_properties(&docs);
let trigger_character = properties
.get("trigger_character")
.map(|v| v.chars().next().unwrap());
let mut includes = HashSet::new();
let mut excludes = HashSet::new();
@ -389,6 +397,7 @@ mod tests {
path: ctx.path_for_id(id).unwrap(),
position: ctx.to_lsp_pos(s, &source),
explicit: false,
trigger_character,
trigger_suggest: true,
trigger_parameter_hints: true,
trigger_named_completion: true,