language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-08-04 02:08:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

feat: initialize locale as soon as possible (#1507)

Browse source
This commit is contained in:
Myriad-Dreamin 2025-03-15 12:19:06 +08:00 • committed by GitHub
parent c96ea6d77f
commit 75aa73ba69
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

21
crates/tinymist/src/init.rs
View file

@ -71,11 +71,7 @@ impl Initializer for RegularInit {
/// # Errors
/// Errors if the configuration could not be updated.
fn initialize(self, params: InitializeParams) -> (ServerState, AnySchedulableResponse) {
let (config, err) = Config::from_params(params, self.font_opts);
if let Some(locale) = config.const_config.locale.as_ref() {
tinymist_l10n::set_locale(locale);
}
let (config, err) = Config::extract_params(params, self.font_opts);
let super_init = SuperInit {
client: self.client,
@ -321,7 +317,11 @@ impl Config {
}
/// Creates a new configuration from the lsp initialization parameters.
pub fn from_params(
///
/// The function has side effects:
/// - Getting environment variables.
/// - Setting the locale.
pub fn extract_params(
params: InitializeParams,
font_opts: CompileFontArgs,
) -> (Self, Option<ResponseError>) {
@ -342,6 +342,11 @@ impl Config {
};
let mut config = Config::new(ConstConfig::from(&params), roots, font_opts);
// Sets locale as soon as possible
if let Some(locale) = config.const_config.locale.as_ref() {
tinymist_l10n::set_locale(locale);
}
let err = params.initialization_options.and_then(|init| {
config
.update(&init)
@ -1227,7 +1232,7 @@ mod tests {
#[test]
fn test_default_config_initialize() {
let (_conf, err) =
Config::from_params(InitializeParams::default(), CompileFontArgs::default());
Config::extract_params(InitializeParams::default(), CompileFontArgs::default());
assert!(err.is_none());
}
@ -1237,7 +1242,7 @@ mod tests {
temp_env::with_var("TYPST_PACKAGE_CACHE_PATH", Some(pkg_path), || {
let (conf, err) =
Config::from_params(InitializeParams::default(), CompileFontArgs::default());
Config::extract_params(InitializeParams::default(), CompileFontArgs::default());
assert!(err.is_none());
let applied_cache_path = conf
.compile