language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-11-25 05:22:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: don't match the right paren for arg completion (#1480)

Browse source 
* fix: don't match the right paren for arg completion

* feat: arg_range_math

* fix: fmt
This commit is contained in:
Myriad-Dreamin 2025-03-10 20:50:29 +08:00 • committed by GitHub
parent 1b141868eb
commit 7b35973741
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 32 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/tinymist-query/src/analysis/completion.rs
View file

@ -174,6 +174,16 @@ impl<'a> CompletionCursor<'a> {
let syntax_context = classify_context(leaf.clone(), Some(cursor));
let surrounding_syntax = surrounding_syntax(&leaf);
// todo: don't match here?
if matches!(syntax, Some(SyntaxClass::Callee(..)))
&& matches!(syntax_context.as_ref(), Some(
SyntaxContext::Element { container, .. } |
SyntaxContext::Arg { args: container, .. } |
SyntaxContext::Paren { container, .. }) if container.rightmost_leaf().map(|s| s.offset()) == Some(leaf.offset()))
{
return None;
}
crate::log_debug_ct!("CompletionCursor: syntax {leaf:?} -> {syntax:#?}");
crate::log_debug_ct!("CompletionCursor: context {leaf:?} -> {syntax_context:#?}");
crate::log_debug_ct!("CompletionCursor: surrounding {leaf:?} -> {surrounding_syntax:#?}");

2
crates/tinymist-query/src/fixtures/completion/arg_range.typ Normal file
View file

@ -0,0 +1,2 @@
/// contains: alignment
#align()/* range 0..1 */

2
crates/tinymist-query/src/fixtures/completion/arg_range_math.typ Normal file
View file

@ -0,0 +1,2 @@
/// contains: size
$norm(x)/* range 0..1 */$

9
crates/tinymist-query/src/fixtures/completion/snaps/test@arg_range.typ.snap Normal file
View file

@ -0,0 +1,9 @@
---
source: crates/tinymist-query/src/completion.rs
description: Completion on / (32..33)
expression: "JsonRepr::new_pure(results)"
input_file: crates/tinymist-query/src/fixtures/completion/arg_range.typ
---
[
null
]

9
crates/tinymist-query/src/fixtures/completion/snaps/test@arg_range_math.typ.snap Normal file
View file

@ -0,0 +1,9 @@
---
source: crates/tinymist-query/src/completion.rs
description: Completion on / (27..28)
expression: "JsonRepr::new_pure(results)"
input_file: crates/tinymist-query/src/fixtures/completion/arg_range_math.typ
---
[
null
]