language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-07-25 05:33:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: client-side control to whether issue completion callback (#744)

Browse source 
* feat: client-side control to whether issue completion callback

* fix: bad changes
This commit is contained in:
Myriad-Dreamin 2024-10-29 13:00:57 +08:00 • committed by GitHub
parent 5dd1226cdc
commit 9c87fe2fb4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 87 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/tinymist-query/src/completion.rs
View file

@ -45,6 +45,12 @@ pub struct CompletionRequest {
pub position: LspPosition,
/// Whether the completion is triggered explicitly.
pub explicit: bool,
/// Whether to trigger suggest completion, a.k.a. auto-completion.
pub trigger_suggest: bool,
/// Whether to trigger named parameter completion.
pub trigger_named_completion: bool,
/// Whether to trigger parameter hint, a.k.a. signature help.
pub trigger_parameter_hints: bool,
}
impl StatefulRequest for CompletionRequest {
@ -131,7 +137,16 @@ impl StatefulRequest for CompletionRequest {
let is_incomplete = false;
let mut items = completion_result.or_else(|| {
let mut cc_ctx = CompletionContext::new(ctx, doc, &source, cursor, explicit)?;
let mut cc_ctx = CompletionContext::new(
ctx,
doc,
&source,
cursor,
explicit,
self.trigger_suggest,
self.trigger_parameter_hints,
self.trigger_named_completion,
)?;
// Exclude it self from auto completion
// e.g. `#let x = (1.);`
@ -372,6 +387,9 @@ mod tests {
path: ctx.path_for_id(id).unwrap(),
position: ctx.to_lsp_pos(s, &source),
explicit: false,
trigger_suggest: true,
trigger_parameter_hints: true,
trigger_named_completion: true,
};
results.push(request.request(ctx, doc.clone()).map(|resp| match resp {
CompletionResponse::List(l) => CompletionResponse::List(CompletionList {