From a5b4533bf7ab175a9bb92e518edf209ceab2ec7e Mon Sep 17 00:00:00 2001 From: Hong Jiarong Date: Sun, 16 Nov 2025 19:15:41 +0800 Subject: [PATCH] clippy --- crates/tinymist-query/src/analysis/code_action.rs | 12 +++--------- crates/tinymist-query/src/code_action.rs | 4 ++-- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/crates/tinymist-query/src/analysis/code_action.rs b/crates/tinymist-query/src/analysis/code_action.rs index 1b9970dd8..8cb7aadc9 100644 --- a/crates/tinymist-query/src/analysis/code_action.rs +++ b/crates/tinymist-query/src/analysis/code_action.rs @@ -79,7 +79,7 @@ impl<'a> CodeActionWorker<'a> { continue; }; - let Some(diag_range) = self.ctx.to_typst_range(diag.range.clone(), &self.source) else { + let Some(diag_range) = self.ctx.to_typst_range(diag.range, &self.source) else { continue; }; @@ -396,14 +396,8 @@ impl<'a> CodeActionWorker<'a> { return None; } - let Some(binding_ident) = bindings.first() else { - return None; - }; - - let Some(binding_node) = decl_node.find(binding_ident.span()) else { - return None; - }; - + let binding_ident = bindings.first()?; + let binding_node = decl_node.find(binding_ident.span())?; if binding_node.range() != *name_range { return None; } diff --git a/crates/tinymist-query/src/code_action.rs b/crates/tinymist-query/src/code_action.rs index b417d57e2..269c527f4 100644 --- a/crates/tinymist-query/src/code_action.rs +++ b/crates/tinymist-query/src/code_action.rs @@ -147,7 +147,7 @@ mod tests { let request = CodeActionRequest { path: path.clone(), - range: diag.range.clone(), + range: diag.range, context: CodeActionContext { diagnostics: vec![diag.clone()], only: None, @@ -163,7 +163,7 @@ mod tests { } let actions = REDACT_LOC.redact(serde_json::to_value(&actions).unwrap()); - let range = JsonRepr::range(&diag.range); + let range = JsonRepr::range(diag.range); entries.push(( range.clone(), json!({