language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-08-04 02:08:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

fix: convert two touched panics to log::warn in signature checker (#934)

Browse source
This commit is contained in:
Myriad-Dreamin 2024-12-03 17:02:40 +08:00 • committed by GitHub
parent b38e9bdf0e
commit e8b8188c1f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/tinymist-query/src/analysis/signature.rs
View file

@ -231,7 +231,12 @@ pub(crate) fn sig_of_type(
let sig_ty = Ty::Func(ty.sig_repr(true, &mut ty_ctx)?);
let sig_ty = type_info.simplify(sig_ty, false);
let Ty::Func(sig_ty) = sig_ty else {
panic!("expected function type, got {sig_ty:?}");
static WARN_ONCE: std::sync::Once = std::sync::Once::new();
WARN_ONCE.call_once(|| {
// todo: seems like a bug
log::warn!("expected function type, got {sig_ty:?}");
});
return None;
};
// todo: this will affect inlay hint: _var_with
@ -251,7 +256,12 @@ pub(crate) fn sig_of_type(
let mut _broken = false;
if docstring.pos.len() != sig_ty.positional_params().len() {
panic!("positional params mismatch: {docstring:#?} != {sig_ty:#?}");
static WARN_ONCE: std::sync::Once = std::sync::Once::new();
WARN_ONCE.call_once(|| {
// todo: seems like a bug
log::warn!("positional params mismatch: {docstring:#?} != {sig_ty:#?}");
});
return None;
}
for (doc, ty) in docstring.pos.iter().zip(sig_ty.positional_params()) {