language-servers/tinymist
1
0
Fork 0
mirror of https://github.com/Myriad-Dreamin/tinymist.git synced 2025-12-23 08:47:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat: add clear_diagnostics method to CompileHandlerImpl for better diagnostic management

Browse source
This commit is contained in:
Hong Jiarong 2025-12-09 19:55:50 +08:00
parent b1871fbfa3
commit fa443289d4
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/tinymist/src/project.rs
View file

@ -519,6 +519,11 @@ impl ProjectClient for mpsc::UnboundedSender<LspInterrupt> {
}
impl CompileHandlerImpl {
/// Clears both compiler and lint diagnostics for the given project version.
fn clear_diagnostics(&self, dv: ProjVersion) {
self.push_diagnostics(dv.clone(), DiagKind::Compiler, None);
self.push_diagnostics(dv, DiagKind::Lint, None);
}
/// Pushes diagnostics to the editor.
fn push_diagnostics(
&self,
@ -540,8 +545,7 @@ impl CompileHandlerImpl {
// todo: better way to remove diagnostics
let valid = !art.world().entry_state().is_inactive();
if !valid {
self.push_diagnostics(dv.clone(), DiagKind::Compiler, None);
self.push_diagnostics(dv, DiagKind::Lint, None);
self.clear_diagnostics(dv);
return;
}
@ -717,8 +721,7 @@ impl CompileHandler<LspCompilerFeat, ProjectInsStateExt> for CompileHandlerImpl
id: rep.id.clone(),
revision,
};
self.push_diagnostics(dv.clone(), DiagKind::Compiler, None);
self.push_diagnostics(dv, DiagKind::Lint, None);
self.clear_diagnostics(dv);
}
#[cfg(feature = "preview")]
@ -747,8 +750,7 @@ impl CompileHandler<LspCompilerFeat, ProjectInsStateExt> for CompileHandlerImpl
// todo: race condition with notify_compile?
// remove diagnostics
self.push_diagnostics(dv.clone(), DiagKind::Compiler, None);
self.push_diagnostics(dv, DiagKind::Lint, None);
self.clear_diagnostics(dv);
}
fn notify_compile(&self, art: &LspCompiledArtifact) {