From 0b39ff3c8f526fbcf6a84d3e232e5a44b7e3fd36 Mon Sep 17 00:00:00 2001 From: Keavon Chambers Date: Wed, 16 Apr 2025 23:49:11 -0700 Subject: [PATCH] Restore CI workflow for Clippy --- .github/workflows/build-dev-and-ci.yml | 11 +---------- .github/workflows/comment-clippy-warnings.yaml | 9 +-------- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/.github/workflows/build-dev-and-ci.yml b/.github/workflows/build-dev-and-ci.yml index 4e443817c..deff77c92 100644 --- a/.github/workflows/build-dev-and-ci.yml +++ b/.github/workflows/build-dev-and-ci.yml @@ -62,6 +62,7 @@ jobs: mold -run npm run build - name: 📤 Publish to Cloudflare Pages + if: ${{ !github.event.pull_request.head.repo.fork }} id: cloudflare uses: cloudflare/pages-action@1 continue-on-error: true @@ -91,16 +92,6 @@ jobs: run: | mold -run cargo test --all-features --workspace - # miri: - # runs-on: self-hosted - - # steps: - # - uses: actions/checkout@v3 - - # - name: 🧪 Run Rust miri - # run: | - # mold -run cargo +nightly miri nextest run -j32 --all-features - cargo-deny: runs-on: ubuntu-latest diff --git a/.github/workflows/comment-clippy-warnings.yaml b/.github/workflows/comment-clippy-warnings.yaml index 07acaaea2..5ee9b62f5 100644 --- a/.github/workflows/comment-clippy-warnings.yaml +++ b/.github/workflows/comment-clippy-warnings.yaml @@ -9,9 +9,7 @@ jobs: clippy: name: Run Clippy runs-on: ubuntu-latest - # TODO(Keavon): Find a workaround (passing the output text to a separate action with permission to read the secrets?) that allows this to work on fork PRs - if: false - # if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork }} + if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork }} permissions: contents: read pull-requests: write @@ -26,11 +24,6 @@ jobs: override: true components: clippy - - name: Install deps - run: | - sudo apt update - sudo apt install libgtk-3-dev libsoup2.4-dev libjavascriptcoregtk-4.0-dev libwebkit2gtk-4.0-dev - - name: Run Clippy id: clippy run: |