mirrors/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2025-08-27 00:14:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Refactor document node type lookup function to fix performance degradation over time (#1878)

Browse source 
* Refactor document_node_types function

* Fix node introspection

* Implement diff based type updates

* Fix missing monitor nodes

* Improve docs and fix warings

* Fix wrongful removal of node paths

* Remove code examples for non pub methodsü

* Code review

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert 2024-08-09 02:37:28 +02:00 • committed by GitHub
parent 06a409f1c5
commit 0dfddd529b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 460 additions and 282 deletions
Download patch file Download diff file Expand all files Collapse all files

15
node-graph/wgpu-executor/src/lib.rs
View file

@ -28,7 +28,7 @@ use web_sys::HtmlCanvasElement;
pub struct WgpuExecutor {
pub context: Context,
render_configuration: RenderConfiguration,
vello_renderer: std::sync::Mutex<vello::Renderer>,
vello_renderer: futures::lock::Mutex<vello::Renderer>,
}
impl std::fmt::Debug for WgpuExecutor {
@ -160,11 +160,12 @@ impl WgpuExecutor {
width,
height,
antialiasing_method: AaConfig::Msaa8,
debug: DebugLayers::all(),
// This setting can be used to visualize things like bounding boxes used for rendering
debug: DebugLayers::none(),
};
{
let mut renderer = self.vello_renderer.lock().unwrap();
let mut renderer = self.vello_renderer.lock().await;
for (id, texture) in context.ressource_overrides.iter() {
let texture_view = wgpu::ImageCopyTextureBase {
texture: texture.clone(),
@ -536,14 +537,12 @@ impl WgpuExecutor {
#[cfg(not(target_arch = "wasm32"))]
pub fn create_surface(&self, window: SurfaceHandle<Window>) -> Result<SurfaceHandle<Surface>> {
let size = window.surface.inner_size();
let resolution = UVec2::new(size.width, size.height);
let surface = self.context.instance.create_surface(wgpu::SurfaceTarget::Window(Box::new(window.surface)))?;
Ok(SurfaceHandle {
window_id: window.window_id,
surface: Surface {
inner: surface,
resolution: UVec2::ZERO,
},
surface: Surface { inner: surface, resolution },
})
}
}
@ -967,7 +966,7 @@ pub struct UploadTextureNode<Executor> {
#[node_macro::node_fn(UploadTextureNode)]
async fn upload_texture<'a: 'input>(input: ImageFrame<Color>, executor: &'a WgpuExecutor) -> TextureFrame {
// let new_data: Vec<RGBA16F> = input.image.data.into_iter().map(|c| c.into()).collect();
let new_data = input.image.data.into_iter().map(|c| SRGBA8::from(c)).collect();
let new_data = input.image.data.into_iter().map(SRGBA8::from).collect();
let new_image = Image {
width: input.image.width,
height: input.image.height,