mirrors/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2025-08-23 22:44:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Eliminate bare Graphic and Artboard graph data by making Merge and Artboard nodes internally use tables (#2996)

Browse source 
* Eliminate bare Graphic and Artboard graph data by making Merge and Artboard nodes internally use tables

* Make the Extend node user-facing
This commit is contained in:
Keavon Chambers 2025-08-05 02:24:12 -07:00 • committed by GitHub
parent 836a110c72
commit 2e1396462c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
22 changed files with 292 additions and 200 deletions
Download patch file Download diff file Expand all files Collapse all files

18
node-graph/gsvg-renderer/src/renderer.rs
View file

@ -827,7 +827,7 @@ impl Render for Artboard {
});
}
// Contents group (includes the artwork but not the background)
// Content group (includes the artwork but not the background)
render.parent_tag(
// SVG group tag
"g",
@ -851,7 +851,7 @@ impl Render for Artboard {
attributes.push("clip-path", selector);
}
},
// Artboard contents
// Artboard content
|render| {
self.group.render_svg(render, render_params);
},
@ -1067,9 +1067,9 @@ impl Render for Table<Raster<CPU>> {
metadata.click_targets.insert(element_id, vec![ClickTarget::new_with_subpath(subpath, 0.)]);
metadata.upstream_footprints.insert(element_id, footprint);
// TODO: Find a way to handle more than one row of the graphical data table
if let Some(image) = self.iter().next() {
metadata.local_transforms.insert(element_id, *image.transform);
// TODO: Find a way to handle more than one row of the raster table
if let Some(raster) = self.iter().next() {
metadata.local_transforms.insert(element_id, *raster.transform);
}
}
@ -1125,9 +1125,9 @@ impl Render for Table<Raster<GPU>> {
metadata.click_targets.insert(element_id, vec![ClickTarget::new_with_subpath(subpath, 0.)]);
metadata.upstream_footprints.insert(element_id, footprint);
// TODO: Find a way to handle more than one row of the graphical data table
if let Some(image) = self.iter().next() {
metadata.local_transforms.insert(element_id, *image.transform);
// TODO: Find a way to handle more than one row of the raster table
if let Some(raster) = self.iter().next() {
metadata.local_transforms.insert(element_id, *raster.transform);
}
}
@ -1165,7 +1165,7 @@ impl Render for Graphic {
}
Graphic::Vector(vector) => {
metadata.upstream_footprints.insert(element_id, footprint);
// TODO: Find a way to handle more than one row of the graphical data table
// TODO: Find a way to handle more than one row of the vector table
if let Some(vector) = vector.iter().next() {
metadata.first_element_source_id.insert(element_id, *vector.source_node_id);
metadata.local_transforms.insert(element_id, *vector.transform);