mirrors/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2025-08-03 21:08:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Remove usage of 'null' in favor of 'undefined'

Browse source
This commit is contained in:
Keavon Chambers 2022-08-25 21:32:27 -07:00
parent 1e74ccb4f8
commit 33cb6fcb00
21 changed files with 45 additions and 323 deletions
Download patch file Download diff file Expand all files Collapse all files

8
frontend/vue.config.js
View file

@ -75,7 +75,7 @@ module.exports = {
};
function formatThirdPartyLicenses(jsLicenses) {
let rustLicenses = null;
let rustLicenses;
if (process.env.NODE_ENV === "production" && process.env.SKIP_CARGO_ABOUT === undefined) {
try {
rustLicenses = generateRustLicenses();
@ -83,7 +83,7 @@ function formatThirdPartyLicenses(jsLicenses) {
// Nothing to show. Error messages were printed above.
}
if (rustLicenses === null) {
if (rustLicenses === undefined) {
// This is probably caused by cargo about not being installed
console.error(`
Could not run \`cargo about\`, which is required to generate license information.
@ -187,13 +187,13 @@ function generateRustLicenses() {
// Cargo returns 101 when the subcommand wasn't found
console.error("cargo-about failed", status, stderr);
}
return null;
return undefined;
}
// Make sure the output starts as expected, we don't want to eval an error message.
if (!stdout.trim().startsWith("GENERATED_BY_CARGO_ABOUT:")) {
console.error("Unexpected output from cargo-about", stdout);
return null;
return undefined;
}
// Security-wise, eval() isn't any worse than require(), but it doesn't need a temporary file.