Rename tools: "Sample" to "Eyedropper", "Blur/Sharpen" to "Detail" (#87)

This commit is contained in:
Keavon Chambers 2021-04-29 00:50:55 -07:00
parent b6ce559d86
commit 3b32184906
8 changed files with 14 additions and 14 deletions

View file

@ -53,7 +53,7 @@ We are also focusing initial feature development on a destructive SVG vector edi
- Tool system - Tool system
- Tools: Line, rectangle, ellipse, and shape - Tools: Line, rectangle, ellipse, and shape
- Tools: Pen and path - Tools: Pen and path
- Tools: Select, crop, navigate, sample - Tools: Select, crop, navigate, eyedropper
- SVG import and export - SVG import and export
## Technology stack ## Technology stack

View file

@ -52,7 +52,7 @@
<ShelfItem title="Select Tool (V)" :active="activeTool === 'Select'" @click="selectTool('Select')"><SelectTool /></ShelfItem> <ShelfItem title="Select Tool (V)" :active="activeTool === 'Select'" @click="selectTool('Select')"><SelectTool /></ShelfItem>
<ShelfItem title="Crop Tool" :active="activeTool === 'Crop'" @click="'tool not implemented' || selectTool('Crop')"><CropTool /></ShelfItem> <ShelfItem title="Crop Tool" :active="activeTool === 'Crop'" @click="'tool not implemented' || selectTool('Crop')"><CropTool /></ShelfItem>
<ShelfItem title="Navigate Tool" :active="activeTool === 'Navigate'" @click="'tool not implemented' || selectTool('Navigate')"><NavigateTool /></ShelfItem> <ShelfItem title="Navigate Tool" :active="activeTool === 'Navigate'" @click="'tool not implemented' || selectTool('Navigate')"><NavigateTool /></ShelfItem>
<ShelfItem title="Sample Tool" :active="activeTool === 'Sample'" @click="'tool not implemented' || selectTool('Sample')"><SampleTool /></ShelfItem> <ShelfItem title="Eyedropper Tool" :active="activeTool === 'Eyedropper'" @click="'tool not implemented' || selectTool('Eyedropper')"><EyedropperTool /></ShelfItem>
<ItemDivider horizontal /> <ItemDivider horizontal />
@ -66,7 +66,7 @@
<ShelfItem title="Heal Tool" :active="activeTool === 'Heal'" @click="'tool not implemented' || selectTool('Heal')"><HealTool /></ShelfItem> <ShelfItem title="Heal Tool" :active="activeTool === 'Heal'" @click="'tool not implemented' || selectTool('Heal')"><HealTool /></ShelfItem>
<ShelfItem title="Clone Tool" :active="activeTool === 'Clone'" @click="'tool not implemented' || selectTool('Clone')"><CloneTool /></ShelfItem> <ShelfItem title="Clone Tool" :active="activeTool === 'Clone'" @click="'tool not implemented' || selectTool('Clone')"><CloneTool /></ShelfItem>
<ShelfItem title="Patch Tool" :active="activeTool === 'Patch'" @click="'tool not implemented' || selectTool('Patch')"><PatchTool /></ShelfItem> <ShelfItem title="Patch Tool" :active="activeTool === 'Patch'" @click="'tool not implemented' || selectTool('Patch')"><PatchTool /></ShelfItem>
<ShelfItem title="Blur/Sharpen Tool" :active="activeTool === 'BlurSharpen'" @click="'tool not implemented' || selectTool('BlurSharpen')"><BlurSharpenTool /></ShelfItem> <ShelfItem title="Detail Tool" :active="activeTool === 'BlurSharpen'" @click="'tool not implemented' || selectTool('BlurSharpen')"><BlurSharpenTool /></ShelfItem>
<ShelfItem title="Relight Tool" :active="activeTool === 'Relight'" @click="'tool not implemented' || selectTool('Relight')"><RelightTool /></ShelfItem> <ShelfItem title="Relight Tool" :active="activeTool === 'Relight'" @click="'tool not implemented' || selectTool('Relight')"><RelightTool /></ShelfItem>
<ItemDivider horizontal /> <ItemDivider horizontal />
@ -198,7 +198,7 @@ import ResetColorsButton from "../../../assets/svg/16x16-bounds-12x12-icon/reset
import SelectTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-select.svg"; import SelectTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-select.svg";
import CropTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-crop.svg"; import CropTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-crop.svg";
import NavigateTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-navigate.svg"; import NavigateTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-navigate.svg";
import SampleTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-sample.svg"; import EyedropperTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-layout-eyedropper.svg";
import TextTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-parametric-text.svg"; import TextTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-parametric-text.svg";
import FillTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-parametric-fill.svg"; import FillTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-parametric-fill.svg";
import GradientTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-parametric-gradient.svg"; import GradientTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-parametric-gradient.svg";
@ -206,7 +206,7 @@ import BrushTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool
import HealTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-heal.svg"; import HealTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-heal.svg";
import CloneTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-clone.svg"; import CloneTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-clone.svg";
import PatchTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-patch.svg"; import PatchTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-patch.svg";
import BlurSharpenTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-blur-sharpen.svg"; import BlurSharpenTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-detail.svg";
import RelightTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-relight.svg"; import RelightTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-raster-relight.svg";
import PathTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-vector-path.svg"; import PathTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-vector-path.svg";
import PenTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-vector-pen.svg"; import PenTool from "../../../assets/svg/24x24-bounds-24x24-icon/document-tool-vector-pen.svg";
@ -253,7 +253,7 @@ export default defineComponent({
SelectTool, SelectTool,
CropTool, CropTool,
NavigateTool, NavigateTool,
SampleTool, EyedropperTool,
TextTool, TextTool,
FillTool, FillTool,
GradientTool, GradientTool,

View file

@ -18,7 +18,7 @@ default = ["console_error_panic_hook"]
[dependencies] [dependencies]
console_error_panic_hook = { version = "0.1.6", optional = true } console_error_panic_hook = { version = "0.1.6", optional = true }
editor-core = { path = "../../../core/editor", package = "graphite-editor-core" } editor-core = { path = "../../../core/editor", package = "graphite-editor-core" }
wasm-bindgen = "0.2.72" wasm-bindgen = "0.2.73"
log = "0.4" log = "0.4"
[dev-dependencies] [dev-dependencies]

View file

@ -42,7 +42,7 @@ pub fn translate_tool(name: &str) -> Option<ToolType> {
Select, Select,
Crop, Crop,
Navigate, Navigate,
Sample, Eyedropper,
Text, Text,
Fill, Fill,
Gradient, Gradient,

View file

@ -6,9 +6,9 @@ use document_core::Operation;
use super::DocumentToolData; use super::DocumentToolData;
#[derive(Default)] #[derive(Default)]
pub struct Sample; pub struct Eyedropper;
impl Tool for Sample { impl Tool for Eyedropper {
fn handle_input(&mut self, event: &Event, document: &Document, tool_data: &DocumentToolData) -> (Vec<Response>, Vec<Operation>) { fn handle_input(&mut self, event: &Event, document: &Document, tool_data: &DocumentToolData) -> (Vec<Response>, Vec<Operation>) {
todo!("{}::handle_input {:?} {:?} {:?}", module_path!(), event, document, tool_data) todo!("{}::handle_input {:?} {:?} {:?}", module_path!(), event, document, tool_data)
} }

View file

@ -1,11 +1,11 @@
mod crop; mod crop;
mod ellipse; mod ellipse;
mod eyedropper;
mod line; mod line;
mod navigate; mod navigate;
mod path; mod path;
mod pen; mod pen;
mod rectangle; mod rectangle;
mod sample;
mod select; mod select;
mod shape; mod shape;
@ -61,7 +61,7 @@ impl Default for ToolFsmState {
Select => select::Select, Select => select::Select,
Crop => crop::Crop, Crop => crop::Crop,
Navigate => navigate::Navigate, Navigate => navigate::Navigate,
Sample => sample::Sample, Eyedropper => eyedropper::Eyedropper,
Path => path::Path, Path => path::Path,
Pen => pen::Pen, Pen => pen::Pen,
Line => line::Line, Line => line::Line,
@ -114,7 +114,7 @@ pub enum ToolType {
Select, Select,
Crop, Crop,
Navigate, Navigate,
Sample, Eyedropper,
Text, Text,
Fill, Fill,
Gradient, Gradient,
@ -142,7 +142,7 @@ impl fmt::Display for ToolType {
Select, Select,
Crop, Crop,
Navigate, Navigate,
Sample, Eyedropper,
Text, Text,
Fill, Fill,
Gradient, Gradient,