mirrors/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2025-07-08 00:05:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add todo comment for fixing replacements by reference

Browse source
This commit is contained in:
Dennis Kobert 2025-03-05 22:46:21 +01:00 • committed by Keavon Chambers
parent 5d797aabe3
commit 659f9c6044
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
editor/src/messages/portfolio/portfolio_message_handler/upgrade.rs
View file

@ -184,6 +184,10 @@ fn upgrade_network(document: &mut DocumentMessageHandler, network_path: &[NodeId
if let Err(e) = upgrade_node_manual_composition(network_interface, node_id, network_path) {
log::error!("Failed to upgrade manual composition for node {node_id}: {e}");
}
// TODO: This does not work for nested nodes because we can't access
// the reference of nodes in subgraphs
// Get node metadata
let node_metadata = match network_metadata.persistent_metadata.node_metadata.get(node_id) {
Some(metadata) => metadata,
@ -232,9 +236,6 @@ fn upgrade_network(document: &mut DocumentMessageHandler, network_path: &[NodeId
log::error!("Failed to upgrade node {node_id} from definition: {e}");
}
}
// Recursively upgrade sub-networks if this node has them
// Note: Would need network traversal logic here if nodes can have sub-networks
}
Ok(())