mirrors/IronRDP
1
0
Fork 0
mirror of https://github.com/Devolutions/IronRDP.git synced 2025-08-04 15:18:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(server): check client size

Browse source 
It's problematic when the client didn't resize, as we send bitmap
updates that don't fit. The client will likely drop the connection.
Let's have a warning for this case in the server.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This commit is contained in:
Marc-André Lureau 2025-01-21 23:32:25 +04:00 • committed by Benoît Cortier
parent e21c5568a4
commit 0f9877ad39
1 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

22
crates/ironrdp-server/src/server.rs
View file

@ -679,6 +679,28 @@ impl RdpServer {
bail!("Fastpath output not supported!");
}
}
CapabilitySet::Bitmap(b) => {
if !b.desktop_resize_flag {
debug!("Desktop resize is not supported by the client");
continue;
}
let client_size = DesktopSize {
width: b.desktop_width,
height: b.desktop_height,
};
let display_size = self.display.lock().await.size().await;
// It's problematic when the client didn't resize, as we send bitmap updates that don't fit.
// The client will likely drop the connection.
if client_size.width < display_size.width || client_size.height < display_size.height {
// TODO: we may have different behaviour instead, such as clipping or scaling?
warn!(
"Client size doesn't fit the server size: {:?} < {:?}",
client_size, display_size
);
}
}
CapabilitySet::SurfaceCommands(c) => {
surface_flags = c.flags;
}