mirrors/IronRDP
1
0
Fork 0
mirror of https://github.com/Devolutions/IronRDP.git synced 2025-07-07 17:45:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

refactor(client): remove redundant value_parser option (#853)
Some checks are pending
CI / Web Client (push) Blocked by required conditions
Details
CI / Fuzzing (push) Blocked by required conditions
Details
CI / Check formatting (push) Waiting to run
Details
CI / Check typos (push) Waiting to run
Details
CI / Checks [linux] (push) Blocked by required conditions
Details
CI / Checks [macos] (push) Blocked by required conditions
Details
CI / Checks [windows] (push) Blocked by required conditions
Details
CI / FFI (push) Blocked by required conditions
Details
CI / Success (push) Blocked by required conditions
Details
Coverage / Coverage Report (push) Waiting to run
Details
Release crates / Open release PR (push) Waiting to run
Details
Release crates / Release crates (push) Waiting to run
Details

Browse source 
This option is only relevant when specifying a value parser different
than the default one.
This commit is contained in:
Benoît Cortier 2025-07-03 06:09:45 -04:00 • committed by GitHub
parent cf21250dcc
commit 9c99133569
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

24
crates/ironrdp-client/src/config.rs
View file

@ -177,22 +177,22 @@ impl FromStr for DvcProxyInfo {
#[clap(version, long_about = None)] #[clap(version, long_about = None)]
struct Args { struct Args {
/// A file with IronRDP client logs /// A file with IronRDP client logs
#[clap(short, long, value_parser)] #[clap(short, long)]
log_file: Option<String>, log_file: Option<String>,
/// An address on which the client will connect. /// An address on which the client will connect.
destination: Option<Destination>, destination: Option<Destination>,
/// A target RDP server user name /// A target RDP server user name
#[clap(short, long, value_parser)] #[clap(short, long)]
username: Option<String>, username: Option<String>,
/// An optional target RDP server domain name /// An optional target RDP server domain name
#[clap(short, long, value_parser)] #[clap(short, long)]
domain: Option<String>, domain: Option<String>,
/// A target RDP server user password /// A target RDP server user password
#[clap(short, long, value_parser)] #[clap(short, long)]
password: Option<String>, password: Option<String>,
/// Proxy URL to connect to for the RDCleanPath /// Proxy URL to connect to for the RDCleanPath
@ -204,23 +204,23 @@ struct Args {
rdcleanpath_token: Option<String>, rdcleanpath_token: Option<String>,
/// The keyboard type /// The keyboard type
#[clap(long, value_enum, value_parser, default_value_t = KeyboardType::IbmEnhanced)] #[clap(long, value_enum, default_value_t = KeyboardType::IbmEnhanced)]
keyboard_type: KeyboardType, keyboard_type: KeyboardType,
/// The keyboard subtype (an original equipment manufacturer-dependent value) /// The keyboard subtype (an original equipment manufacturer-dependent value)
#[clap(long, value_parser, default_value_t = 0)] #[clap(long, default_value_t = 0)]
keyboard_subtype: u32, keyboard_subtype: u32,
/// The number of function keys on the keyboard /// The number of function keys on the keyboard
#[clap(long, value_parser, default_value_t = 12)] #[clap(long, default_value_t = 12)]
keyboard_functional_keys_count: u32, keyboard_functional_keys_count: u32,
/// The input method editor (IME) file name associated with the active input locale /// The input method editor (IME) file name associated with the active input locale
#[clap(long, value_parser, default_value_t = String::from(""))] #[clap(long, default_value_t = String::from(""))]
ime_file_name: String, ime_file_name: String,
/// Contains a value that uniquely identifies the client /// Contains a value that uniquely identifies the client
#[clap(long, value_parser, default_value_t = String::from(""))] #[clap(long, default_value_t = String::from(""))]
dig_product_id: String, dig_product_id: String,
/// Enable thin client /// Enable thin client
@ -266,11 +266,11 @@ struct Args {
no_credssp: bool, no_credssp: bool,
/// The clipboard type /// The clipboard type
#[clap(long, value_enum, value_parser, default_value_t = ClipboardType::Default)] #[clap(long, value_enum, default_value_t = ClipboardType::Default)]
clipboard_type: ClipboardType, clipboard_type: ClipboardType,
/// The bitmap codecs to use (remotefx:on, ...) /// The bitmap codecs to use (remotefx:on, ...)
#[clap(long, value_parser, num_args = 1.., value_delimiter = ',')] #[clap(long, num_args = 1.., value_delimiter = ',')]
codecs: Vec<String>, codecs: Vec<String>,
/// Add DVC channel named pipe proxy. /// Add DVC channel named pipe proxy.
@ -278,7 +278,7 @@ struct Args {
/// e.g. `ChannelName=PipeName` where `ChannelName` is the name of the channel, /// e.g. `ChannelName=PipeName` where `ChannelName` is the name of the channel,
/// and `PipeName` is the name of the named pipe to connect to (without OS-specific prefix), /// and `PipeName` is the name of the named pipe to connect to (without OS-specific prefix),
/// e.g. PipeName will automatically be prefixed with `\\.\pipe\` on Windows. /// e.g. PipeName will automatically be prefixed with `\\.\pipe\` on Windows.
#[clap(long, value_parser)] #[clap(long)]
dvc_proxy: Vec<DvcProxyInfo>, dvc_proxy: Vec<DvcProxyInfo>,
} }