dependabot[bot]
f31af061b9
build(deps): bump rstest from 0.25.0 to 0.26.1 ( #1052 )
2025-12-09 00:17:45 -05:00
Alex Yusiuk
924330159a
chore: enable large_futures clippy lint ( #1046 )
...
CI / Check formatting (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Check typos (push) Waiting to run
CI / Checks [macos] (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
> It checks for the size of a Future created by async fn or async {}.
The maximum byte size a `Future` can have, before it triggers the
clippy::large_futures lint is by default 16384, but we can adjust it.
2025-12-03 08:07:33 -05:00
Alex Yusiuk
9622619e8c
refactor: add as_conversions clippy correctness lint ( #1021 )
...
CI / Check formatting (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Coverage / Coverage Report (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
Co-authored-by: Benoît CORTIER <git.divisible626@passmail.com>
2025-11-05 22:23:22 +00:00
Alex Yusiuk
abc391c134
refactor: add partial_pub_fields clippy style and readability lint ( #976 )
CI / Check formatting (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Coverage / Coverage Report (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
2025-10-23 10:58:41 -04:00
Alex Yusiuk
e87048c19b
refactor: get rid of lazy_static ( #1022 )
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-10-20 15:07:19 -04:00
Alex Yusiuk
82dbb6460f
refactor(ironrdp-pdu)!: fix as_conversions clippy lint warnings ( #967 )
...
Co-authored-by: Benoît CORTIER <git.divisible626@passmail.com>
2025-10-07 09:36:58 +00:00
Alex Yusiuk
af8ebdcfa2
refactor: enable missing_panics_doc clippy lint ( #1006 )
...
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Success (push) Blocked by required conditions
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
> Checks the doc comments of publicly visible functions that may panic
and warns if there is no # Panics section.
Co-authored-by: Benoît Cortier <3809077+CBenoit@users.noreply.github.com>
2025-10-06 09:19:22 +00:00
Alex Yusiuk
ce298d1c19
refactor: enable self_named_module_files clippy lint ( #1007 )
...
Coverage / Coverage Report (push) Has been cancelled
CI / Check formatting (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
> Checks that module layout uses only mod.rs files.
2025-10-03 05:37:14 -04:00
Alex Yusiuk
a8289bf63f
refactor: enable unnecessary_self_imports clippy lint ( #1005 )
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-10-02 05:10:55 -04:00
Alex Yusiuk
bbc38db750
chore: enable try_err clippy lint ( #1004 )
2025-10-02 08:34:02 +00:00
Alex Yusiuk
49a0a9e6d2
chore: enable rest_pat_in_fully_bound_structs clippy lint ( #1003 )
2025-10-02 04:05:34 -04:00
Alex Yusiuk
b91a4eeb01
refactor: enable redundant_type_annotations clippy lint ( #1001 )
CI / Check formatting (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Coverage / Coverage Report (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
2025-09-30 09:45:22 -04:00
Alex Yusiuk
4f518f0a7b
chore: add infinite_loop clippy style and readability lint ( #981 )
...
> Checks for infinite loops in a function where the return type is not !
and lint accordingly.
> Making the return type ! serves as documentation that the function
does not return. If the function is not intended to loop infinitely,
then this lint may detect a bug.
2025-09-19 12:14:08 +00:00
Alex Yusiuk
0141178ae2
chore: add empty_enum_variants_with_brackets clippy style and readability lint ( #980 )
...
> Finds enum variants without fields that are declared with empty
brackets.
> Empty brackets after a enum variant declaration are redundant and can
be omitted, and it may be desirable to do so consistently for style.
2025-09-19 11:58:28 +00:00
Alex Yusiuk
c417012b38
refactor: add deref_by_slicing clippy style and readability lint ( #979 )
...
> Checks for slicing expressions which are equivalent to dereferencing
the value.
> Some people may prefer to dereference rather than slice.
2025-09-19 11:43:30 +00:00
Alex Yusiuk
42fbd5f378
refactor: add multiple_inherent_impl clippy style and readability lint ( #978 )
...
From the lint
[documentation](https://rust-lang.github.io/rust-clippy/master/index.html#/multiple_inherent_impl ):
> Checks for multiple inherent implementations of a struct
> Splitting the implementation of a type makes the code harder to
navigate.
2025-09-19 11:27:49 +00:00
Alex Yusiuk
4cf86ffdba
refactor: add map_with_unused_argument_over_ranges clippy style and readability lint ( #982 )
...
> Checks for Iterator::map over ranges without using the parameter which
could be more clearly expressed using std::iter::repeat(...).take(...)
or std::iter::repeat_n.
2025-09-19 11:05:53 +00:00
Alex Yusiuk
fe47ced857
chore: add pub_without_shorthand clippy style and readability lint ( #977 )
...
CI / Check formatting (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Coverage / Coverage Report (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
[pub_without_shorthand](https://rust-lang.github.io/rust-clippy/master/index.html#/pub_without_shorthand ):
> Checks for usage of pub(<loc>) without in.
> Note: As you cannot write a module’s path in pub(<loc>), this will
only trigger on pub(super) and the like.
2025-09-11 11:53:10 +00:00
Alex Yusiuk
630525deae
refactor!: enable unwrap_used clippy correctness lint ( #965 )
...
Co-authored-by: Benoît CORTIER <git.divisible626@passmail.com>
2025-09-11 11:41:02 +00:00
Alex Yusiuk
a8b6fb1d74
chore: add suspicious_xor_user_as_pow clippy correctness lint ( #973 )
...
CI / Checks [macos] (push) Blocked by required conditions
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
From the lint
[docs](https://rust-lang.github.io/rust-clippy/stable/index.html#suspicious_xor_used_as_pow ):
> Warns for a Bitwise XOR (^) operator being probably confused as a
powering. It will not trigger if any of the numbers are not in decimal.
It’s most probably a typo and may lead to unexpected behaviours.
2025-09-10 13:04:12 +00:00
Alex Yusiuk
898df8c0fa
chore: add unused_result_ok clippy correctness lint ( #974 )
...
This lint checks for calls to `Result::ok()` without using the returned
`Option`.
2025-09-10 08:47:12 -04:00
Benoît CORTIER
8a8027481f
build: optimize binary size for FFI builds
...
Still optimizing for performance, but enabled the following options:
> strip = "symbols"
> codegen-units = 1
> lto = true
- Baseline: 8.9M
- New: 5.6M
2025-09-09 13:24:10 -04:00
Alex Yusiuk
2259bd7706
refactor: add string_slice clippy correctness lint ( #970 )
...
This lint checks for slice operations on strings.
From `string_slice`
[docs](https://rust-lang.github.io/rust-clippy/master/index.html#/string_slice ):
> UTF-8 characters span multiple bytes, and it is easy to inadvertently
confuse character counts and string indices. This may lead to panics,
and should warrant some test cases containing wide UTF-8 characters.
This lint is most useful in code that should avoid panics at all costs.
2025-09-09 04:22:29 -04:00
Alex Yusiuk
ae99d14a69
refactor: add same_name_method clippy correctness lint ( #948 )
2025-08-28 11:05:42 +00:00
Alex Yusiuk
2c7f976ecf
chore: add rc_mutex clippy correctness lint ( #945 )
CI / Checks [macos] (push) Blocked by required conditions
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-08-27 12:13:00 -04:00
Alex Yusiuk
998ef87f96
chore: add float_cmp_const clippy correctness lint ( #943 )
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-08-27 05:03:32 -04:00
Alex Yusiuk
76e4ac230a
chore: add precedence_bits clippy correctness lint ( #942 )
2025-08-27 05:03:01 -04:00
Alex Yusiuk
f34a9f2500
refactor: add panic clippy correctness lint ( #934 )
2025-08-26 10:52:01 -04:00
Alex Yusiuk
b1f6004ab1
refactor: add non_ascii_literal clippy correctness lint ( #932 )
2025-08-26 08:18:22 -04:00
Alex Yusiuk
8fe288400d
chore: add filetype_is_file clippy correctness lint ( #933 )
2025-08-26 07:57:08 -04:00
Alex Yusiuk
6fddcaae38
refactor: add needless_raw_strings clippy correctness lint ( #931 )
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Check formatting (push) Waiting to run
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Release crates / Release crates (push) Waiting to run
CI / Web Client (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
2025-08-25 07:17:25 -04:00
Alex Yusiuk
ff2c968052
chore: add mixed_read_write_in_expression clippy correctness lint ( #929 )
...
CI / Check formatting (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Coverage / Coverage Report (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
`mixed_read_write_in_expression` checks for a read and a write to the
same variable, where whether the read occurs before or after the write
depends on the evaluation order of sub-expressions.
2025-08-22 06:28:26 -04:00
Alex Yusiuk
5fe6043208
chore: add mem_forget clippy correctness lint ( #928 )
...
This lint warns on usage of `std::mem::forget`. If it's needed, we
should silence the lint and justify that it's used mindfully.
2025-08-22 05:42:06 -04:00
Alex Yusiuk
514400f6fc
chore: add lossy_float_literal clippy correctness lint ( #926 )
...
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
This lint checks the float literals that cannot be represented as the
underlying type without loss.
2025-08-21 04:18:41 -04:00
Alex Yusiuk
e01f38f3a8
chore: add trivial_numeric_casts rustc style/readability lint ( #925 )
2025-08-20 11:27:38 -04:00
Alex Yusiuk
a6e0364be7
chore: add redundant_lifetimes rustc style/readability lint ( #924 )
2025-08-20 06:28:55 -04:00
Alex Yusiuk
1fdbfd29ed
refactor: add redundant_imports rustc style/readability lint ( #923 )
2025-08-20 03:12:31 -04:00
Alex Yusiuk
c84b46be91
refactor: add macro_use_extern_crate rustc style/readability lint ( #919 )
...
This lint warns on each `macro_use` attribute on an extern crate. Such a
way of importing macros from a crate is being phased out. Instead of it,
we should directly import the needed macro using `use` import.
2025-08-19 09:45:34 -04:00
Alex Yusiuk
64535c5559
refactor: add wildcard_imports clippy extra-pedantic lint ( #902 )
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-08-18 13:49:02 -04:00
Alex Yusiuk
39566bff58
chore: add clippy cfg_not_test extra-pedantic lint ( #903 )
CI / Check formatting (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Coverage / Coverage Report (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
2025-07-31 13:10:19 -04:00
Alex Yusiuk
32b0e40eca
refactor: add unused_trait_names clippy extra-pedantic lint ( #900 )
2025-07-31 03:57:09 -04:00
Alex Yusiuk
9a9ab63e1c
refactor: add non_zero_suggestions clippy extra-pedantic lint ( #895 )
2025-07-30 09:11:53 +00:00
Alex Yusiuk
00f2f1b067
refactor: add renamed_function_params clippy extra-pedantic lint ( #898 )
2025-07-30 08:56:01 +00:00
Alex Yusiuk
721c680f9b
chore: add rustc "Correctness" lints ( #886 )
2025-07-25 12:51:30 -04:00
Marc-André Lureau
fc8f8ee279
build(deps): bump rstest to 0.25
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2025-07-24 06:34:50 -04:00
Alex Yusiuk
e7393f50d0
chore: add disallowed_script_idents clippy extra-pedantic lint ( #881 )
CI / Checks [linux] (push) Blocked by required conditions
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-07-23 11:29:27 -04:00
Alex Yusiuk
f96b1b2ce8
refactor: add allow_attributes clippy to "Extra-pedantic clippy" section ( #880 )
CI / Checks [windows] (push) Blocked by required conditions
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
2025-07-23 08:55:40 +00:00
Alex Yusiuk
061ccf2f0a
chore: add todo clippy lint to "Let’s not merge unintended" section ( #876 )
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-07-22 08:31:06 -04:00
Alex Yusiuk
aa82dfb1fd
refactor: add more clippy lints to "Compile-time / optimization" section ( #875 )
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-07-21 12:28:33 -04:00
Alexandr Yusiuk
5484b11fbd
refactor: add missing_safety_doc clippy safety lint
CI / Check formatting (push) Has been cancelled
CI / Check typos (push) Has been cancelled
Coverage / Coverage Report (push) Has been cancelled
Release crates / Open release PR (push) Has been cancelled
Release crates / Release crates (push) Has been cancelled
CI / Checks [linux] (push) Has been cancelled
CI / Checks [macos] (push) Has been cancelled
CI / Checks [windows] (push) Has been cancelled
CI / Fuzzing (push) Has been cancelled
CI / Web Client (push) Has been cancelled
CI / FFI (push) Has been cancelled
CI / Success (push) Has been cancelled
2025-07-18 16:39:23 -04:00
