Commit graph

46 commits

Author SHA1 Message Date
Alex Yusiuk
64535c5559
refactor: add wildcard_imports clippy extra-pedantic lint (#902)
Some checks are pending
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-08-18 13:49:02 -04:00
Alex Yusiuk
32b0e40eca
refactor: add unused_trait_names clippy extra-pedantic lint (#900) 2025-07-31 03:57:09 -04:00
Marc-André Lureau
4a40883f2b refactor(cliprdr-native): hand-implement Error trait
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2025-07-24 06:34:50 -04:00
Alex Yusiuk
f96b1b2ce8
refactor: add allow_attributes clippy to "Extra-pedantic clippy" section (#880)
Some checks are pending
CI / Checks [windows] (push) Blocked by required conditions
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
2025-07-23 08:55:40 +00:00
Alex Yusiuk
aa82dfb1fd
refactor: add more clippy lints to "Compile-time / optimization" section (#875)
Some checks are pending
CI / Check formatting (push) Waiting to run
CI / Check typos (push) Waiting to run
CI / Checks [linux] (push) Blocked by required conditions
CI / Checks [macos] (push) Blocked by required conditions
CI / Checks [windows] (push) Blocked by required conditions
CI / Fuzzing (push) Blocked by required conditions
CI / Web Client (push) Blocked by required conditions
CI / FFI (push) Blocked by required conditions
CI / Success (push) Blocked by required conditions
Coverage / Coverage Report (push) Waiting to run
Release crates / Open release PR (push) Waiting to run
Release crates / Release crates (push) Waiting to run
2025-07-21 12:28:33 -04:00
Alexandr Yusiuk
dc5da26fb9 refactor: add unnecessary_safety_comment clippy safety lint 2025-07-18 16:39:23 -04:00
devolutionsbot
aa6777b56a
chore(release): prepare for publishing (#748) 2025-05-27 15:21:56 +00:00
Vladyslav Nikonov
135b8bc4f6
build(deps): update windows crate to 0.61.1 (#743) 2025-04-09 08:54:48 +00:00
Marc-Andre Lureau
4e581e0f47
feat(cliprdr)!: add on_ready() callback (#729)
Give a hint to the backend when the channel is actually connected &
ready to process messages.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2025-03-30 18:39:10 -04:00
devolutionsbot
b19008c029
chore(release): prepare for publishing (#699) 2025-03-13 09:06:30 +00:00
devolutionsbot
92dd927ec2
chore(release): prepare for publishing (#696) 2025-03-12 16:40:47 +00:00
Benoît Cortier
c21fa44fd6
build: do not use workspace dependencies (#695)
As written in the workspace Cargo.toml:

> Note that for better cross-tooling interactions, do not use workspace
dependencies for anything that is not "workspace internal" (e.g.: mostly
dev-dependencies). E.g.: release-plz can’t detect that a dependency has
been
updated in a way warranting a version bump in the dependant if no commit
is
touching a file associated to the crate. It is technically okay to use
that
for "private" (i.e.: not used in the public API) dependencies too, but
we
still want to make follow-up releases to stay up to date with the
community,
even for private dependencies.

Expectation is that release-plz will be able to auto-detect when bumping
dependents is necessary.

Closes #689
2025-03-12 09:25:01 -04:00
Benoît Cortier
0b5f691c1e
chore(xtask): update binary dependencies (#663) 2025-02-05 18:12:10 -05:00
devolutionsbot
11b92bfcbd
chore(release): prepare for publishing (#658) 2025-02-03 17:13:59 -05:00
Alex Yusiuk
9b2926ea12
fix(cliprdr-native): handle WM_ACTIVATEAPP in clipboard_subproc (#657)
This PR adds handling of `WM_ACTIVATEAPP` in `clipboard_subproc`.
Previously, the function handled only `WM_ACTIVATE`.
2025-02-03 13:38:31 -05:00
devolutionsbot
e6d6e9d8a7
chore(release): prepare for publishing (#628) 2025-01-28 23:24:35 +00:00
Sébastien Duquette
dd249909a8
docs: use CDN URLs instead of the blob storage URLs for Devolutions logo (#631) 2025-01-09 10:06:10 -05:00
devolutionsbot
97ef9f0acb
chore(release): prepare for publishing (#611) 2024-12-14 14:32:28 +00:00
Benoît Cortier
0c10367ebc
chore: symlinks to license files in packages (#604)
Add symlinks to the license files in crates that we are publishing on
crates.io.
2024-12-11 08:13:26 -05:00
Benoît CORTIER
294af1cc5c style: cargo +nightly fmt 2024-11-20 01:28:31 +09:00
Benoît CORTIER
807eb59b07 refactor: enable clippy::std_instead_of_core lint 2024-11-20 01:28:31 +09:00
Benoît CORTIER
d9b69c68f9 build: enable unused_crate_dependencies lint
All reported cases were actually unused dependencies.
2024-11-20 01:28:31 +09:00
Marc-André Lureau
5381b24444 docs: use Devolutions logo
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-10-29 19:14:20 +09:00
Marc-André Lureau
4ef36bf5fa docs: add project links to READMEs for consistency
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-10-29 19:14:20 +09:00
Marc-André Lureau
76b0518afa refactor(core): move IntoOwned
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-08-30 00:05:16 -04:00
Marc-André Lureau
7419467ad3 refactor(core): move cursor.rs
Add documentation.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-08-30 00:05:16 -04:00
Marc-André Lureau
4154ceea05 refactor(core): move impl_as_any macros
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-08-30 00:05:16 -04:00
Benoît Cortier
0f238097e0 refactor: follow-up review for PR 523 2024-08-11 22:26:02 -04:00
Marc-André Lureau
1a878d950a chore(deps): use common workspace windows version
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-08-11 22:26:02 -04:00
Marc-André Lureau
cfd60a1412 refactor(cliprdr-native): bump windows dep to 0.58
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-08-11 22:26:02 -04:00
Marc-André Lureau
8f14abdf1e feat(cliprdr-native): drop need for win32 HWND instance
Create a hidden window instead. This allows for easier setup of
clipboard channels while the GUI may not be ready yet.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-08-11 22:26:02 -04:00
Vladyslav Nikonov
00de2164be
fix(cliprdr): exposed HWND for Windows native cliprdr API (#510) 2024-07-26 11:47:03 -04:00
Marc-André Lureau
7307148cb8 chore: use workspace lints
Among other things, this allows tools and LSP to pick up our settings.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-07-24 04:35:32 -04:00
Marc-André Lureau
3a805761e7 fix(cliprdr-native): warn(renamed_and_removed_lints)
warning: lint `pointer_structural_match` has been removed: converted
into hard error, see RFC #3535
<https://rust-lang.github.io/rfcs/3535-constants-in-patterns.html> for
more information

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-07-24 04:35:32 -04:00
Marc-André Lureau
5962d0d2cb feat(cliprdr-native): publicly export StubCliprdrBackend
This will allow the server example to implement a custom CliprdrServerFactory.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-04-05 13:05:04 -04:00
Isaiah Becker-Mayer
04d78b6581
refactor: dynamic resize follow up (#425) 2024-04-01 12:21:54 -04:00
Vladyslav Nikonov
d53a5321b2
feat(displaycontrol): dynamic resolution PDUs (#366) 2024-02-14 19:32:02 +02:00
Marc-André Lureau
f8a982dbda feat(cliprdr-native): add stub
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2024-01-15 13:21:51 +09:00
Benoît CORTIER
c1ac51904f refactor(cliprdr): fix typos 2023-11-20 09:39:36 -05:00
Benoît Cortier
76e3a35df1
style: normalize casing of error messages (#274)
Error messages should start by a lowercase so it’s easier to compose
with other error messages and the final casing is left up to the "error
reporter" down the line. This is the convention adopted by the Rust
project:

- https://rust-lang.github.io/api-guidelines/interoperability.html
- https://doc.rust-lang.org/stable/std/error/trait.Error.html
2023-11-13 17:06:48 +02:00
Isaiah Becker-Mayer
40e5581de3
feat: adds AsAny bound on CliprdrBackend (#219) 2023-10-16 19:40:20 +00:00
Benoît CORTIER
b6407a688a build: update dependencies 2023-10-05 10:58:16 -04:00
Benoît CORTIER
622a0457bc build: relax some dependencies
In general we don’t need to specify as far as the patch version for
our dependencies.
2023-10-05 10:58:16 -04:00
Benoît Cortier
3d98cd1d94
refactor: enable elided_lifetimes_in_paths lint (#203)
Hiding the lifetimes is making the code less obvious.

That’s not a problem for types that I know about intimately such as
`ReadCursor` or `WriteCursor`, but I actually found myself surprised
more than once when reading code I didn’t authored, discovering  later
there was in fact a hidden lifetime parameter.
I expect this problem to be worse for someone not familiar with
our codebase.

I understand this lint is "allow" by default because in some cases
it leads to writing unergonomic ugly code when a type has many generic
lifetimes parameters:

```
TyCtxt<'_, '_, '_>
```

However we _never_ work with more than one generic lifetime parameter in
IronRDP codebase, so it seems to me that the tradeoff towards clarity is
worth it, in our case.
2023-10-04 09:14:36 -07:00
Benoît Cortier
6283e37937
refactor: check for additional lints (#200) 2023-10-02 13:46:05 +03:00
Vladyslav Nikonov
6b660fa298
feat(cliprdr): Clipboard support for Windows (#194)
Includes refactoring changes by @ibeckermayer from #196 and #197

Co-authored-by: Isaiah Becker-Mayer <isaiah@goteleport.com>
2023-09-27 14:45:47 -04:00