mirrors/LibCST
1
0
Fork 0
mirror of https://github.com/Instagram/LibCST.git synced 2025-12-23 10:35:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

use LocalScope in ScopeVisitor._new_scope to simplify typing

Browse source
This commit is contained in:
Jimmy Lai 2019-09-27 10:46:20 -07:00 • committed by jimmylai
parent 894a0f7424
commit e24ca294b6
2 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
libcst/metadata/scope_provider.py
View file

@ -359,14 +359,10 @@ class ScopeVisitor(cst.CSTVisitor):
@contextmanager
def _new_scope(
self, kind: Type[Scope], name: Optional[str] = None
self, kind: Type[LocalScope], name: Optional[str] = None
) -> Iterator[None]:
parent_scope = self.scope
if issubclass(kind, LocalScope):
# pyre-ignore: pyre cannot understand issubclass and complained the extra name arg
self.scope = kind(parent_scope, name)
else:
self.scope = kind(parent_scope)
self.scope = kind(parent_scope, name)
try:
yield
finally:

8
libcst/metadata/tests/test_scope_provider.py
View file

@ -642,5 +642,11 @@ class ScopeProviderTest(UnitTest):
self.assertEqual(
scope_of_f.get_fully_qualified_names_for(cst.Name(value=builtin)),
{f"builtins.{builtin}"},
f"test builtin: {builtin}",
f"Test builtin: {builtin}.",
)
self.assertEqual(
scope_of_module.get_fully_qualified_names_for(cst.Name(value="d")),
set(),
"Test variable d in global scope.",
)