mirrors/RustPython-Parser
1
0
Fork 0
mirror of https://github.com/RustPython/Parser.git synced 2025-07-08 05:35:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #4402 from harupy/remove-unreachable-if

Browse source 
Remove unreachable code in `compiler/parser/src/string_parser.rs`
This commit is contained in:
Jim Fasarakis-Hilliard 2023-01-02 17:05:45 +02:00 • committed by GitHub
commit d691527ead
1 changed files with 6 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

29
parser/src/string_parser.rs
View file

@ -219,35 +219,18 @@ impl<'a> StringParser<'a> {
Some('a') => ConversionFlag::Ascii,
Some('r') => ConversionFlag::Repr,
Some(_) => {
return Err(if expression.trim().is_empty() {
EmptyExpression.to_lexical_error(self.get_pos())
} else {
InvalidConversionFlag.to_lexical_error(self.get_pos())
});
return Err(InvalidConversionFlag.to_lexical_error(self.get_pos()));
}
None => {
return Err(if expression.trim().is_empty() {
EmptyExpression.to_lexical_error(self.get_pos())
} else {
UnclosedLbrace.to_lexical_error(self.get_pos())
});
return Err(UnclosedLbrace.to_lexical_error(self.get_pos()));
}
};
if let Some(&peek) = self.peek() {
if peek != '}' && peek != ':' {
return Err(if expression.trim().is_empty() {
EmptyExpression.to_lexical_error(self.get_pos())
} else {
UnclosedLbrace.to_lexical_error(self.get_pos())
});
match self.peek() {
Some('}' | ':') => {}
Some(_) | None => {
return Err(UnclosedLbrace.to_lexical_error(self.get_pos()))
}
} else {
return Err(if expression.trim().is_empty() {
EmptyExpression.to_lexical_error(self.get_pos())
} else {
UnclosedLbrace.to_lexical_error(self.get_pos())
});
}
}