From 02c27732af47537003fe2d88a806dd56a925a634 Mon Sep 17 00:00:00 2001 From: Andrew Grigorev Date: Tue, 1 Jul 2025 11:56:26 +0300 Subject: [PATCH] fix: Remove existing model settings before adding new ones Fix #4298 Co-authored-by: aider (vertex_ai/gemini-2.5-pro) --- aider/models.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/aider/models.py b/aider/models.py index ae76f0342..84260d607 100644 --- a/aider/models.py +++ b/aider/models.py @@ -1052,12 +1052,10 @@ def register_models(model_settings_fnames): for model_settings_dict in model_settings_list: model_settings = ModelSettings(**model_settings_dict) - existing_model_settings = next( - (ms for ms in MODEL_SETTINGS if ms.name == model_settings.name), None - ) - if existing_model_settings: - MODEL_SETTINGS.remove(existing_model_settings) + # Remove all existing settings for this model name + MODEL_SETTINGS[:] = [ms for ms in MODEL_SETTINGS if ms.name != model_settings.name] + # Add the new settings MODEL_SETTINGS.append(model_settings) except Exception as e: raise Exception(f"Error loading model settings from {model_settings_fname}: {e}")