mirrors/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils.git synced 2025-12-23 08:47:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #9700 from sylvestre/issue-9699

Browse source 
kill -1 should trigger an error
This commit is contained in:
Daniel Hofstetter 2025-12-19 09:32:07 +01:00 • committed by GitHub
commit 2d3aebce67
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/uu/kill/src/kill.rs
View file

@ -137,8 +137,8 @@ pub fn uu_app() -> Command {
}
fn handle_obsolete(args: &mut Vec<String>) -> Option<usize> {
// Sanity check
if args.len() > 2 {
// Sanity check - need at least the program name and one argument
if args.len() >= 2 {
// Old signal can only be in the first argument position
let slice = args[1].as_str();
if let Some(signal) = slice.strip_prefix('-') {

24
tests/by-util/test_kill.rs
View file

@ -395,3 +395,27 @@ fn test_kill_with_signal_and_table() {
.arg("-t")
.fails();
}
/// Test that `kill -1` (signal without PID) reports "no process ID" error
/// instead of being misinterpreted as pid=-1 which would kill all processes.
/// This matches GNU kill behavior.
#[test]
fn test_kill_signal_only_no_pid() {
// Test with -1 (SIGHUP)
new_ucmd!()
.arg("-1")
.fails()
.stderr_contains("no process ID specified");
// Test with -9 (SIGKILL)
new_ucmd!()
.arg("-9")
.fails()
.stderr_contains("no process ID specified");
// Test with -TERM
new_ucmd!()
.arg("-TERM")
.fails()
.stderr_contains("no process ID specified");
}