From 4b02a38be5ed4ee604a78a48fa9345320587dab3 Mon Sep 17 00:00:00 2001
From: FidelSch <honoratofidel@gmail.com>
Date: Wed, 19 Nov 2025 20:36:26 -0300
Subject: [PATCH] ln: add error handling for hard link creation on directories

---
 src/uu/ln/locales/en-US.ftl |  1 +
 src/uu/ln/locales/fr-FR.ftl |  1 +
 src/uu/ln/src/ln.rs         |  8 ++++++++
 tests/by-util/test_ln.rs    | 16 ++++++++++++++++
 4 files changed, 26 insertions(+)

diff --git a/src/uu/ln/locales/en-US.ftl b/src/uu/ln/locales/en-US.ftl
index 85315070d..54755c7dc 100644
--- a/src/uu/ln/locales/en-US.ftl
+++ b/src/uu/ln/locales/en-US.ftl
@@ -35,4 +35,5 @@ ln-prompt-replace = replace {$file}?
 ln-cannot-backup = cannot backup {$file}
 ln-failed-to-access = failed to access {$file}
 ln-failed-to-create-hard-link = failed to create hard link {$source} => {$dest}
+ln-failed-to-create-hard-link-dir = {$source}: hard link not allowed for directory
 ln-backup = backup: {$backup}
diff --git a/src/uu/ln/locales/fr-FR.ftl b/src/uu/ln/locales/fr-FR.ftl
index 483f15c92..f037528c6 100644
--- a/src/uu/ln/locales/fr-FR.ftl
+++ b/src/uu/ln/locales/fr-FR.ftl
@@ -36,4 +36,5 @@ ln-prompt-replace = remplacer {$file} ?
 ln-cannot-backup = impossible de sauvegarder {$file}
 ln-failed-to-access = échec d'accès à {$file}
 ln-failed-to-create-hard-link = échec de création du lien physique {$source} => {$dest}
+ln-failed-to-create-hard-link-dir = {$source} : lien physique non autorisé pour un répertoire
 ln-backup = sauvegarde : {$backup}
diff --git a/src/uu/ln/src/ln.rs b/src/uu/ln/src/ln.rs
index a3fde8f4a..e287dfa97 100644
--- a/src/uu/ln/src/ln.rs
+++ b/src/uu/ln/src/ln.rs
@@ -62,6 +62,9 @@ enum LnError {
 
     #[error("{}", translate!("ln-error-extra-operand", "operand" => _0.to_string_lossy(), "program" => _1.clone()))]
     ExtraOperand(OsString, String),
+
+    #[error("{}", translate!("ln-failed-to-create-hard-link-dir", "source" => _0.to_string_lossy()))]
+    FailedToCreateHardLinkDir(PathBuf),
 }
 
 impl UError for LnError {
@@ -431,6 +434,11 @@ fn link(src: &Path, dst: &Path, settings: &Settings) -> UResult<()> {
     if settings.symbolic {
         symlink(&source, dst)?;
     } else {
+        // Cannot create hard link to a directory
+        if src.is_dir() {
+            return Err(LnError::FailedToCreateHardLinkDir(source.to_path_buf()).into());
+        }
+
         let p = if settings.logical && source.is_symlink() {
             // if we want to have an hard link,
             // source is a symlink and -L is passed
diff --git a/tests/by-util/test_ln.rs b/tests/by-util/test_ln.rs
index d5a7bbfbb..bfcbc4e71 100644
--- a/tests/by-util/test_ln.rs
+++ b/tests/by-util/test_ln.rs
@@ -934,3 +934,19 @@ fn test_ln_non_utf8_paths() {
     let symlink_path = at.plus(symlink_name);
     assert!(symlink_path.is_symlink());
 }
+
+#[test]
+fn test_ln_hard_link_dir() {
+    let scene = TestScenario::new(util_name!());
+    let at = &scene.fixtures;
+
+    at.mkdir("dir");
+
+    let result = scene.ucmd().args(&["dir", "dir_link"]).fails();
+
+    assert!(
+        result
+            .stderr_str()
+            .contains("hard link not allowed for directory")
+    );
+}