mirrors/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils.git synced 2025-12-23 08:47:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

util(cksum): Fix unexpected fail when giving --length 0 to wrong algorithm

Browse source
This commit is contained in:
Dorian Peron 2025-10-26 14:32:20 +01:00
parent fd83181ac2
commit 4e9d07e86c
2 changed files with 20 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/uu/cksum/src/cksum.rs
View file

@ -383,14 +383,13 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
let input_length = matches.get_one::<usize>(options::LENGTH);
let length = match input_length {
Some(length) => {
if algo_name == ALGORITHM_OPTIONS_BLAKE2B {
calculate_blake2b_length(*length)?
} else {
return Err(ChecksumError::LengthOnlyForBlake2b.into());
}
None | Some(0) => None,
Some(length) if algo_name == ALGORITHM_OPTIONS_BLAKE2B => {
calculate_blake2b_length(*length)?
}
_ => {
return Err(ChecksumError::LengthOnlyForBlake2b.into());
}
None => None,
};
if LEGACY_ALGORITHMS.contains(&algo_name) && check {

14
tests/by-util/test_cksum.rs
View file

@ -348,6 +348,20 @@ fn test_length_with_wrong_algorithm() {
.stderr_contains("cksum: --length is only supported with --algorithm=blake2b");
}
/// Giving --length to a wrong algorithm doesn't fail if the length is zero
#[test]
fn test_length_is_zero_with_wrong_algorithm() {
for algo in ["md5", "crc", "sha1", "sha224", "sha256", "sha384", "sha512"] {
new_ucmd!()
.arg("--length=0")
.args(&["-a", algo])
.arg("lorem_ipsum.txt")
.succeeds()
.no_stderr()
.stdout_is_fixture(format!("{algo}_single_file.expected"));
}
}
#[test]
fn test_length_not_supported() {
new_ucmd!()