mirrors/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils.git synced 2025-12-23 08:47:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #8939 from naoNao89/fix/sort-benchmark-variance
Some checks failed
CICD / Style/cargo-deny (push) Waiting to run
Details
CICD / Style/deps (push) Waiting to run
Details
CICD / Documentation/warnings (push) Waiting to run
Details
CICD / MinRustV (push) Waiting to run
Details
CICD / Separate Builds (push) Waiting to run
Details
CICD / Dependencies (push) Waiting to run
Details
CICD / Build/Makefile (push) Blocked by required conditions
Details
CICD / Build/stable (push) Blocked by required conditions
Details
CICD / Build/nightly (push) Blocked by required conditions
Details
CICD / Binary sizes (push) Blocked by required conditions
Details
CICD / Build (push) Blocked by required conditions
Details
CICD / Tests/BusyBox test suite (push) Blocked by required conditions
Details
CICD / Tests/Toybox test suite (push) Blocked by required conditions
Details
CICD / Code Coverage (push) Waiting to run
Details
CICD / Safe Traversal Security Check (push) Blocked by required conditions
Details
CICD / Test all features separately (push) Blocked by required conditions
Details
CICD / Build/SELinux (push) Blocked by required conditions
Details
CICD / Build/SELinux-Stubs (Non-Linux) (push) Blocked by required conditions
Details
GnuTests / Aggregate GNU test results (push) Blocked by required conditions
Details
Android / Test builds (push) Waiting to run
Details
Benchmarks / Run benchmarks (CodSpeed) (push) Waiting to run
Details
FreeBSD / Style and Lint (push) Waiting to run
Details
GnuTests / Run GNU tests (native) (push) Waiting to run
Details
GnuTests / Run GNU tests (SELinux) (push) Waiting to run
Details
Code Quality / Style/format (push) Waiting to run
Details
Code Quality / Style/lint (push) Waiting to run
Details
Code Quality / Style/spelling (push) Waiting to run
Details
Code Quality / Style/toml (push) Waiting to run
Details
Code Quality / Style/Python (push) Waiting to run
Details
Code Quality / Pre-commit hooks (push) Waiting to run
Details
Devcontainer / Verify devcontainer (push) Waiting to run
Details
FreeBSD / Tests (push) Waiting to run
Details
WSL2 / Test (push) Waiting to run
Details
Check uudoc Documentation Generation / Verify uudoc generates correct documentation (push) Has been cancelled
Details

Browse source 
Reduce variance in sort benchmarks by reusing temp file
This commit is contained in:
Sylvestre Ledru 2025-10-17 14:56:48 +02:00 • committed by GitHub
commit a255a1f3db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 28 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

49
src/uu/sort/benches/sort_locale_bench.rs
View file

@ -14,16 +14,17 @@ use uucore::benchmark::{run_util_function, setup_test_file, text_data};
fn sort_ascii_c_locale(bencher: Bencher) {
let data = text_data::generate_ascii_data_simple(100_000);
let file_path = setup_test_file(&data);
// Reuse the same output file across iterations to reduce filesystem variance
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap().to_string();
bencher.bench(|| {
unsafe {
env::set_var("LC_ALL", "C");
}
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap();
black_box(run_util_function(
uumain,
&["-o", output_path, file_path.to_str().unwrap()],
&["-o", &output_path, file_path.to_str().unwrap()],
));
});
}
@ -33,16 +34,17 @@ fn sort_ascii_c_locale(bencher: Bencher) {
fn sort_ascii_utf8_locale(bencher: Bencher) {
let data = text_data::generate_ascii_data_simple(200_000);
let file_path = setup_test_file(&data);
// Reuse the same output file across iterations to reduce filesystem variance
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap().to_string();
bencher.bench(|| {
unsafe {
env::set_var("LC_ALL", "en_US.UTF-8");
}
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap();
black_box(run_util_function(
uumain,
&["-o", output_path, file_path.to_str().unwrap()],
&["-o", &output_path, file_path.to_str().unwrap()],
));
});
}
@ -52,16 +54,17 @@ fn sort_ascii_utf8_locale(bencher: Bencher) {
fn sort_mixed_c_locale(bencher: Bencher) {
let data = text_data::generate_mixed_locale_data(50_000);
let file_path = setup_test_file(&data);
// Reuse the same output file across iterations to reduce filesystem variance
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap().to_string();
bencher.bench(|| {
unsafe {
env::set_var("LC_ALL", "C");
}
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap();
black_box(run_util_function(
uumain,
&["-o", output_path, file_path.to_str().unwrap()],
&["-o", &output_path, file_path.to_str().unwrap()],
));
});
}
@ -71,16 +74,17 @@ fn sort_mixed_c_locale(bencher: Bencher) {
fn sort_mixed_utf8_locale(bencher: Bencher) {
let data = text_data::generate_mixed_locale_data(50_000);
let file_path = setup_test_file(&data);
// Reuse the same output file across iterations to reduce filesystem variance
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap().to_string();
bencher.bench(|| {
unsafe {
env::set_var("LC_ALL", "en_US.UTF-8");
}
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap();
black_box(run_util_function(
uumain,
&["-o", output_path, file_path.to_str().unwrap()],
&["-o", &output_path, file_path.to_str().unwrap()],
));
});
}
@ -90,16 +94,17 @@ fn sort_mixed_utf8_locale(bencher: Bencher) {
fn sort_german_c_locale(bencher: Bencher) {
let data = text_data::generate_german_locale_data(50_000);
let file_path = setup_test_file(&data);
// Reuse the same output file across iterations to reduce filesystem variance
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap().to_string();
bencher.bench(|| {
unsafe {
env::set_var("LC_ALL", "C");
}
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap();
black_box(run_util_function(
uumain,
&["-o", output_path, file_path.to_str().unwrap()],
&["-o", &output_path, file_path.to_str().unwrap()],
));
});
}
@ -109,16 +114,17 @@ fn sort_german_c_locale(bencher: Bencher) {
fn sort_german_locale(bencher: Bencher) {
let data = text_data::generate_german_locale_data(50_000);
let file_path = setup_test_file(&data);
// Reuse the same output file across iterations to reduce filesystem variance
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap().to_string();
bencher.bench(|| {
unsafe {
env::set_var("LC_ALL", "de_DE.UTF-8");
}
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap();
black_box(run_util_function(
uumain,
&["-o", output_path, file_path.to_str().unwrap()],
&["-o", &output_path, file_path.to_str().unwrap()],
));
});
}
@ -128,16 +134,17 @@ fn sort_german_locale(bencher: Bencher) {
fn sort_random_strings(bencher: Bencher) {
let data = text_data::generate_random_strings(50_000, 50);
let file_path = setup_test_file(&data);
// Reuse the same output file across iterations to reduce filesystem variance
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap().to_string();
bencher.bench(|| {
unsafe {
env::set_var("LC_ALL", "en_US.UTF-8");
}
let output_file = NamedTempFile::new().unwrap();
let output_path = output_file.path().to_str().unwrap();
black_box(run_util_function(
uumain,
&["-o", output_path, file_path.to_str().unwrap()],
&["-o", &output_path, file_path.to_str().unwrap()],
));
});
}