mirrors/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils.git synced 2025-12-23 08:47:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #9529 from martinkunkel2/dd-print-slow-transfer-rate

Browse source 
dd: Handle slow transfer rates in progress display
This commit is contained in:
Dorian Péron 2025-12-10 12:52:32 +01:00 • committed by GitHub
commit a977c36498
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/uu/dd/src/progress.rs
View file

@ -147,7 +147,7 @@ impl ProgUpdate {
// Compute the throughput (bytes per second) as a string.
let duration = self.duration.as_secs_f64();
let safe_millis = std::cmp::max(1, self.duration.as_millis());
let rate = 1000 * (btotal / safe_millis);
let rate = (1000u128 * btotal) / safe_millis;
let transfer_rate = to_magnitude_and_suffix(rate, SuffixType::Si);
// If we are rewriting the progress line, do write a carriage
@ -644,7 +644,7 @@ mod tests {
prog_update.write_prog_line(&mut cursor, rewrite).unwrap();
assert_eq!(
std::str::from_utf8(cursor.get_ref()).unwrap(),
"1 byte copied, 1 s, 0.0 B/s\n"
"1 byte copied, 1 s, 1.0 B/s\n"
);
let prog_update = prog_update_write(999);
@ -652,7 +652,7 @@ mod tests {
prog_update.write_prog_line(&mut cursor, rewrite).unwrap();
assert_eq!(
std::str::from_utf8(cursor.get_ref()).unwrap(),
"999 bytes copied, 1 s, 0.0 B/s\n"
"999 bytes copied, 1 s, 999 B/s\n"
);
let prog_update = prog_update_write(1000);