mirrors/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils.git synced 2025-12-23 08:47:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #8740 from loskutov/patch-1

Browse source 
uucore: parse_time: avoid expensive `with_scale(9)` for huge inputs
This commit is contained in:
Daniel Hofstetter 2025-09-25 10:20:27 +02:00 • committed by GitHub
commit e028c6b739
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/uucore/src/lib/features/parser/parse_time.rs
View file

@ -80,7 +80,14 @@ pub fn from_str(string: &str, allow_suffixes: bool) -> Result<Duration, String>
// Allow non-negative durations (-0 is fine), and infinity.
let num = match num {
ExtendedBigDecimal::BigDecimal(bd) if !bd.is_negative() => bd,
ExtendedBigDecimal::BigDecimal(bd) if !bd.is_negative() => {
if bd.fractional_digit_count() <= -20 {
// bd >= 10^20 > u64::MAX -- early return to avoid
// potentially expensive to-nanoseconds conversion
return Ok(Duration::MAX);
}
bd
}
ExtendedBigDecimal::MinusZero => 0.into(),
ExtendedBigDecimal::Infinity => return Ok(Duration::MAX),
_ => return Err(format!("invalid time interval {}", string.quote())),
@ -128,6 +135,7 @@ mod tests {
fn test_overflow() {
// u64 seconds overflow (in Duration)
assert_eq!(from_str("9223372036854775808d", true), Ok(Duration::MAX));
assert_eq!(from_str("1e6666666666668320", true), Ok(Duration::MAX));
// ExtendedBigDecimal overflow
assert_eq!(from_str("1e92233720368547758080", false), Ok(Duration::MAX));
assert_eq!(from_str("1e92233720368547758080", false), Ok(Duration::MAX));