mirrors/coreutils
1
0
Fork 0
mirror of https://github.com/uutils/coreutils.git synced 2025-12-23 08:47:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

more: tests: cleanup processes in test_valid_arg

Browse source 
Added cleanup in test_alive to ensure all spawned processes are
terminated on successful test execution.

This also fixes a race condition that could occur: the check for
process is_alive might be executing while more is still parsing
the arguments.
This commit is contained in:
Martin Kunkel 2025-08-04 21:39:02 +02:00
parent 45457cf718
commit ff001139ea
1 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tests/by-util/test_more.rs
View file

@ -46,14 +46,22 @@ fn test_valid_arg() {
fn test_alive(args: &[&str]) {
let (at, mut ucmd) = at_and_ucmd!();
let file = "test_file";
at.touch(file);
ucmd.args(args)
.arg(file)
.run_no_wait()
.make_assertion()
.is_alive();
let content = "test content";
let file = "test_file";
at.write(file, content);
let mut cmd = ucmd.args(args).arg(file).run_no_wait();
// wait for more to start and display the file
while cmd.is_alive() && !cmd.stdout_all().contains(content) {
cmd.delay(50);
}
assert!(cmd.is_alive(), "Command should still be alive");
// cleanup
cmd.kill();
}
#[test]