mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-28 04:35:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #19921: When Path.mkdir() is called with parents=True, any missing parent is created with the default permissions, ignoring the mode argument (mimicking the POSIX "mkdir -p" command).

Browse source 
Patch by Serhiy.
This commit is contained in:
Antoine Pitrou 2013-12-16 20:22:37 +01:00
parent c274fd22ed
commit 0048c98fef
4 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Lib/test/test_pathlib.py
View file

@ -1478,7 +1478,6 @@ class _BasePathTest(object):
with self.assertRaises(OSError) as cm:
p.mkdir()
self.assertEqual(cm.exception.errno, errno.EEXIST)
# XXX test `mode` arg
def test_mkdir_parents(self):
# Creating a chain of directories
@ -1493,7 +1492,17 @@ class _BasePathTest(object):
with self.assertRaises(OSError) as cm:
p.mkdir(parents=True)
self.assertEqual(cm.exception.errno, errno.EEXIST)
# XXX test `mode` arg
# test `mode` arg
mode = stat.S_IMODE(p.stat().st_mode) # default mode
p = self.cls(BASE, 'newdirD', 'newdirE')
p.mkdir(0o555, parents=True)
self.assertTrue(p.exists())
self.assertTrue(p.is_dir())
if os.name != 'nt':
# the directory's permissions follow the mode argument
self.assertEqual(stat.S_IMODE(p.stat().st_mode), 0o555 & mode)
# the parent's permissions follow the default process settings
self.assertEqual(stat.S_IMODE(p.parent.stat().st_mode), mode)
@with_symlinks
def test_symlink_to(self):