mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

gh-116871: Improve name suggestions in tracebacks (GH-116930)

Browse source 
Only include underscored names in name suggestions for AttributeError and
ImportError if the original name was underscored.
This commit is contained in:
Serhiy Storchaka 2024-05-06 15:53:15 +03:00 • committed by GitHub
parent d6fa1d4bee
commit 0085c3ae8f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 45 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Lib/test/test_traceback.py
View file

@ -3882,6 +3882,27 @@ class SuggestionFormattingTestBase:
actual = self.get_suggestion(cls(), 'bluch')
self.assertIn(suggestion, actual)
def test_getattr_suggestions_underscored(self):
class A:
bluch = None
self.assertIn("'bluch'", self.get_suggestion(A(), 'blach'))
self.assertIn("'bluch'", self.get_suggestion(A(), '_luch'))
self.assertIn("'bluch'", self.get_suggestion(A(), '_bluch'))
class B:
_bluch = None
def method(self, name):
getattr(self, name)
self.assertIn("'_bluch'", self.get_suggestion(B(), '_blach'))
self.assertIn("'_bluch'", self.get_suggestion(B(), '_luch'))
self.assertNotIn("'_bluch'", self.get_suggestion(B(), 'bluch'))
self.assertIn("'_bluch'", self.get_suggestion(partial(B().method, '_blach')))
self.assertIn("'_bluch'", self.get_suggestion(partial(B().method, '_luch')))
self.assertIn("'_bluch'", self.get_suggestion(partial(B().method, 'bluch')))
def test_getattr_suggestions_do_not_trigger_for_long_attributes(self):
class A:
blech = None
@ -4074,6 +4095,17 @@ class SuggestionFormattingTestBase:
actual = self.get_import_from_suggestion(code, 'bluch')
self.assertIn(suggestion, actual)
def test_import_from_suggestions_underscored(self):
code = "bluch = None"
self.assertIn("'bluch'", self.get_import_from_suggestion(code, 'blach'))
self.assertIn("'bluch'", self.get_import_from_suggestion(code, '_luch'))
self.assertIn("'bluch'", self.get_import_from_suggestion(code, '_bluch'))
code = "_bluch = None"
self.assertIn("'_bluch'", self.get_import_from_suggestion(code, '_blach'))
self.assertIn("'_bluch'", self.get_import_from_suggestion(code, '_luch'))
self.assertNotIn("'_bluch'", self.get_import_from_suggestion(code, 'bluch'))
def test_import_from_suggestions_do_not_trigger_for_long_attributes(self):
code = "blech = None"