From 011979132648d50f83d4506d768dca24de47c8c6 Mon Sep 17 00:00:00 2001 From: Mae Hood <22501070+biglizards@users.noreply.github.com> Date: Thu, 1 May 2025 00:39:26 +0100 Subject: [PATCH] dict: Remove redundant incref of immortal object Py_EMPTY_KEYS (GH-133200) --- Objects/dictobject.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Objects/dictobject.c b/Objects/dictobject.c index 00658a8ac35..59b0cf1ce7d 100644 --- a/Objects/dictobject.c +++ b/Objects/dictobject.c @@ -4851,7 +4851,8 @@ dict_new(PyTypeObject *type, PyObject *args, PyObject *kwds) d->ma_used = 0; d->_ma_watcher_tag = 0; - dictkeys_incref(Py_EMPTY_KEYS); + // We don't inc ref empty keys because they're immortal + assert((Py_EMPTY_KEYS)->dk_refcnt == _Py_DICT_IMMORTAL_INITIAL_REFCNT); d->ma_keys = Py_EMPTY_KEYS; d->ma_values = NULL; ASSERT_CONSISTENT(d);