mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 10:19:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #10949: Improved robustness of rotating file handlers.

Browse source
This commit is contained in:
Vinay Sajip 2011-01-21 23:35:57 +00:00
parent 00d650baaa
commit 01241d6c35
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/logging/handlers.py
View file

@ -120,6 +120,7 @@ class RotatingFileHandler(BaseRotatingHandler):
""" """
if self.stream: if self.stream:
self.stream.close() self.stream.close()
self.stream = None
if self.backupCount > 0: if self.backupCount > 0:
for i in range(self.backupCount - 1, 0, -1): for i in range(self.backupCount - 1, 0, -1):
sfn = "%s.%d" % (self.baseFilename, i) sfn = "%s.%d" % (self.baseFilename, i)
@ -316,6 +317,7 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
""" """
if self.stream: if self.stream:
self.stream.close() self.stream.close()
self.stream = None
# get the time that this sequence started at and make it a TimeTuple # get the time that this sequence started at and make it a TimeTuple
t = self.rolloverAt - self.interval t = self.rolloverAt - self.interval
if self.utc: if self.utc:

2
Misc/NEWS
View file

@ -16,6 +16,8 @@ Core and Builtins
Library Library
------- -------
- Issue #10949: Improved robustness of rotating file handlers.
- Issue #10955: Fix a potential crash when trying to mmap() a file past its - Issue #10955: Fix a potential crash when trying to mmap() a file past its
length. Initial patch by Ross Lagerwall. length. Initial patch by Ross Lagerwall.