mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-11 04:19:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

[3.12] gh-88118: Fix some test_multiprocessing flakiness. (GH-116434) (GH-116440)

Browse source 
Fix some test_multiprocessing flakiness.

Potentially introduced by https://github.com/python/cpython/pull/25845

not joining that thread likely leads to recently observed "environment
changed" logically passing but overall failing tests seen on some
buildbots similar to:

```
1 test altered the execution environment (env changed):
    test.test_multiprocessing_fork.test_processes

2 re-run tests:
    test.test_multiprocessing_fork.test_processes
    test.test_multiprocessing_forkserver.test_processes
```
(cherry picked from commit ea1803e608)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
This commit is contained in:
Miss Islington (bot) 2024-03-06 23:13:49 +01:00 • committed by GitHub
parent 0a01ed6c2a
commit 01505953f2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Lib/test/_test_multiprocessing.py
View file

@ -3475,15 +3475,20 @@ class _TestListener(BaseTestCase):
client = self.connection.Client(addr, authkey=authkey) client = self.connection.Client(addr, authkey=authkey)
client.send(1729) client.send(1729)
key = b"" key = b''
with self.connection.Listener(authkey=key) as listener: with self.connection.Listener(authkey=key) as listener:
threading.Thread(target=run, args=(listener.address, key)).start() thread = threading.Thread(target=run, args=(listener.address, key))
with listener.accept() as d: thread.start()
self.assertEqual(d.recv(), 1729) try:
with listener.accept() as d:
self.assertEqual(d.recv(), 1729)
finally:
thread.join()
if self.TYPE == 'processes': if self.TYPE == 'processes':
self.assertRaises(OSError, listener.accept) with self.assertRaises(OSError):
listener.accept()
@unittest.skipUnless(util.abstract_sockets_supported, @unittest.skipUnless(util.abstract_sockets_supported,
"test needs abstract socket support") "test needs abstract socket support")