mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-22 09:45:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

#15447: Use subprocess.DEVNULL in webbrowser, instead of opening

Browse source 
This eliminates a ResourceWarning, since before webbrowser was
explicitly opening os.devnull and then leaving it open.  Tests
to follow.

Patch by Anton Barkovsky.
This commit is contained in:
R David Murray 2012-09-03 12:44:29 -04:00
parent d674a770e9
commit 02ca144b92
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/webbrowser.py
View file

@ -230,7 +230,7 @@ class UnixBrowser(BaseBrowser):
cmdline = [self.name] + raise_opt + args
if remote or self.background:
inout = io.open(os.devnull, "r+")
inout = subprocess.DEVNULL
else:
# for TTY browsers, we need stdin/out
inout = None
@ -354,7 +354,7 @@ class Konqueror(BaseBrowser):
else:
action = "openURL"
devnull = io.open(os.devnull, "r+")
devnull = subprocess.DEVNULL
# if possible, put browser in separate process group, so
# keyboard interrupts don't affect browser as well as Python
setsid = getattr(os, 'setsid', None)