mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-23 03:05:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

bpo-29110: Fix file object leak in aifc.open when given invalid AIFF file. (GH-162)

Browse source
This commit is contained in:
Anthony Zhang 2017-02-22 02:23:30 -05:00 • committed by INADA Naoki
parent 0899b98095
commit 03f68b60e1
3 changed files with 33 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/test/test_aifc.py
View file

@ -1,4 +1,4 @@
from test.support import findfile, TESTFN, unlink
from test.support import check_no_resource_warning, findfile, TESTFN, unlink
import unittest
from test import audiotests
from audioop import byteswap
@ -149,6 +149,14 @@ class AifcMiscTest(audiotests.AudioTests, unittest.TestCase):
#This file contains chunk types aifc doesn't recognize.
self.f = aifc.open(findfile('Sine-1000Hz-300ms.aif'))
def test_close_opened_files_on_error(self):
non_aifc_file = findfile('pluck-pcm8.wav', subdir='audiodata')
with check_no_resource_warning(self):
with self.assertRaises(aifc.Error):
# Try opening a non-AIFC file, with the expectation that
# `aifc.open` will fail (without raising a ResourceWarning)
f = self.f = aifc.open(non_aifc_file, 'rb')
def test_params_added(self):
f = self.f = aifc.open(TESTFN, 'wb')
f.aiff()