mirror of
https://github.com/python/cpython.git
synced 2025-07-23 11:15:24 +00:00
bpo-43972: Set content-length to 0 for http.server.SimpleHTTPRequestHandler 301s (GH-25705)
* Set content-length for simple http server 301s
When http.server.SimpleHTTPRequestHandler sends a 301 (Moved
Permanently) due to a missing file, it does not set a Content-Length
of 0. Unfortunately, certain clients can be left waiting for the
connection to be closed in this circumstance, even though no body
will be sent. At time of writing, both curl and Firefox demonstrate
this behavior.
* Test Content-Length on simple http server redirect
When serving a redirect, the SimpleHTTPRequestHandler will now send
`Content-Length: 0`. Several tests for http.server already cover
various behaviors and checks including redirection. This change only
adds one check for the expected Content-Length on the simplest case
for a redirect.
* Add news entry for SimpleHTTPRequestHandler fix
* Clarify the specific kind of 301
Co-authored-by: Senthil Kumaran <skumaran@gatech.edu>
(cherry picked from commit fb42725561
)
Co-authored-by: Stephen Rosen <sirosen@globus.org>
This commit is contained in:
parent
34fc6dd8fd
commit
058f9b27d3
3 changed files with 5 additions and 0 deletions
|
@ -689,6 +689,7 @@ class SimpleHTTPRequestHandler(BaseHTTPRequestHandler):
|
|||
parts[3], parts[4])
|
||||
new_url = urllib.parse.urlunsplit(new_parts)
|
||||
self.send_header("Location", new_url)
|
||||
self.send_header("Content-Length", "0")
|
||||
self.end_headers()
|
||||
return None
|
||||
for index in "index.html", "index.htm":
|
||||
|
|
|
@ -428,6 +428,7 @@ class SimpleHTTPServerTestCase(BaseTestCase):
|
|||
self.check_status_and_reason(response, HTTPStatus.OK)
|
||||
response = self.request(self.base_url)
|
||||
self.check_status_and_reason(response, HTTPStatus.MOVED_PERMANENTLY)
|
||||
self.assertEqual(response.getheader("Content-Length"), "0")
|
||||
response = self.request(self.base_url + '/?hi=2')
|
||||
self.check_status_and_reason(response, HTTPStatus.OK)
|
||||
response = self.request(self.base_url + '?hi=1')
|
||||
|
|
|
@ -0,0 +1,3 @@
|
|||
When :class:`http.server.SimpleHTTPRequestHandler` sends a
|
||||
``301 (Moved Permanently)`` for a directory path not ending with `/`, add a
|
||||
``Content-Length: 0`` header. This improves the behavior for certain clients.
|
Loading…
Add table
Add a link
Reference in a new issue