gh-121245: Refactor site.register_readline() (GH-121659)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This commit is contained in:
Sergey B Kirpichev 2024-07-15 23:12:41 +03:00 committed by GitHub
parent 8b209fd4f8
commit 05d413764c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 36 additions and 36 deletions

View file

@ -517,6 +517,10 @@ def register_readline():
pass
if readline.get_current_history_length() == 0:
try:
from _pyrepl.main import CAN_USE_PYREPL
except ImportError:
CAN_USE_PYREPL = False
# If no history was loaded, default to .python_history,
# or PYTHON_HISTORY.
# The guard is necessary to avoid doubling history size at
@ -524,25 +528,18 @@ def register_readline():
# through a PYTHONSTARTUP hook, see:
# http://bugs.python.org/issue5845#msg198636
history = gethistoryfile()
if os.getenv("PYTHON_BASIC_REPL") or not CAN_USE_PYREPL:
readline_module = readline
else:
readline_module = _pyrepl.readline
try:
if os.getenv("PYTHON_BASIC_REPL"):
readline.read_history_file(history)
else:
_pyrepl.readline.read_history_file(history)
readline_module.read_history_file(history)
except (OSError,* _pyrepl.unix_console._error):
pass
def write_history():
try:
from _pyrepl.main import CAN_USE_PYREPL
except ImportError:
CAN_USE_PYREPL = False
try:
if os.getenv("PYTHON_BASIC_REPL") or not CAN_USE_PYREPL:
readline.write_history_file(history)
else:
_pyrepl.readline.write_history_file(history)
readline_module.write_history_file(history)
except (FileNotFoundError, PermissionError):
# home directory does not exist or is not writable
# https://bugs.python.org/issue19891