mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-19 17:25:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-33316: PyThread_release_lock always fails (GH-6541)

Browse source 
Use correct interpretation of return value from APIs.
This commit is contained in:
native-api 2019-02-02 19:22:55 +03:00 • committed by Steve Dower
parent 00e9c55d27
commit 05e922136a
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Misc/NEWS.d/next/Windows/2018-04-20-03-24-07.bpo-33316.9IiJ8J.rst Normal file
View file

@ -0,0 +1 @@
PyThread_release_lock always fails

5
Python/thread_nt.h
View file

@ -104,8 +104,9 @@ LeaveNonRecursiveMutex(PNRMUTEX mutex)
if (PyMUTEX_LOCK(&mutex->cs)) if (PyMUTEX_LOCK(&mutex->cs))
return FALSE; return FALSE;
mutex->locked = 0; mutex->locked = 0;
result = PyCOND_SIGNAL(&mutex->cv); /* condvar APIs return 0 on success. We need to return TRUE on success. */
result &= PyMUTEX_UNLOCK(&mutex->cs); result = !PyCOND_SIGNAL(&mutex->cv);
PyMUTEX_UNLOCK(&mutex->cs);
return result; return result;
} }