mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-10 00:43:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 18

#11767: use context manager to close file in __getitem__ to prevent FD leak

Browse source 
All of the other methods in mailbox that create message objects take care to
close the file descriptors they use, so it seems to make sense to have
__getitem__ do so as well.

Patch by Filip Gruszczyński.
This commit is contained in:
R David Murray 2011-06-17 12:54:56 -04:00
parent 26de69dff8
commit 05ff990401
3 changed files with 37 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Lib/mailbox.py
View file

@ -20,6 +20,7 @@ import email
import email.message
import email.generator
import io
import contextlib
try:
if sys.platform == 'os2emx':
# OS/2 EMX fcntl() not adequate
@ -76,7 +77,8 @@ class Mailbox:
if not self._factory:
return self.get_message(key)
else:
return self._factory(self.get_file(key))
with contextlib.closing(self.get_file(key)) as file:
return self._factory(file)
def get_message(self, key):
"""Return a Message representation or raise a KeyError."""