mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-26 10:19:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

[3.13] gh-117657: Fix data races reported by TSAN in some set methods (GH-120914) (#121240)

Browse source 
Refactor the fast Unicode hash check into `_PyObject_HashFast` and use relaxed
atomic loads in the free-threaded build.

After this change, the TSAN doesn't report data races for this method.
(cherry picked from commit 294e724964)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
This commit is contained in:
Miss Islington (bot) 2024-07-01 21:40:28 +02:00 • committed by GitHub
parent fc0b1cbdfe
commit 06fd745dd9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 81 additions and 121 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Modules/_collectionsmodule.c
View file

@ -2537,12 +2537,9 @@ _collections__count_elements_impl(PyObject *module, PyObject *mapping,
if (key == NULL)
break;
if (!PyUnicode_CheckExact(key) ||
(hash = _PyASCIIObject_CAST(key)->hash) == -1)
{
hash = PyObject_Hash(key);
if (hash == -1)
goto done;
hash = _PyObject_HashFast(key);
if (hash == -1) {
goto done;
}
oldval = _PyDict_GetItem_KnownHash(mapping, key, hash);