mirror of
https://github.com/python/cpython.git
synced 2025-07-24 11:44:31 +00:00
gh-100809: Fix handling of drive-relative paths in pathlib.Path.absolute() (GH-100812)
Resolving the drive independently uses the OS API, which ensures it starts from the current directory on that drive.
This commit is contained in:
parent
d401b20630
commit
072011b3c3
4 changed files with 64 additions and 1 deletions
|
@ -816,7 +816,12 @@ class Path(PurePath):
|
|||
"""
|
||||
if self.is_absolute():
|
||||
return self
|
||||
return self._from_parts([os.getcwd()] + self._parts)
|
||||
elif self._drv:
|
||||
# There is a CWD on each drive-letter drive.
|
||||
cwd = self._flavour.abspath(self._drv)
|
||||
else:
|
||||
cwd = os.getcwd()
|
||||
return self._from_parts([cwd] + self._parts)
|
||||
|
||||
def resolve(self, strict=False):
|
||||
"""
|
||||
|
|
|
@ -4,6 +4,7 @@ import errno
|
|||
import os
|
||||
import re
|
||||
import stat
|
||||
import string
|
||||
import sys
|
||||
import time
|
||||
import unittest
|
||||
|
@ -716,3 +717,37 @@ class EnvironmentVarGuard(collections.abc.MutableMapping):
|
|||
else:
|
||||
self._environ[k] = v
|
||||
os.environ = self._environ
|
||||
|
||||
|
||||
try:
|
||||
import ctypes
|
||||
kernel32 = ctypes.WinDLL('kernel32', use_last_error=True)
|
||||
|
||||
ERROR_FILE_NOT_FOUND = 2
|
||||
DDD_REMOVE_DEFINITION = 2
|
||||
DDD_EXACT_MATCH_ON_REMOVE = 4
|
||||
DDD_NO_BROADCAST_SYSTEM = 8
|
||||
except (ImportError, AttributeError):
|
||||
def subst_drive(path):
|
||||
raise unittest.SkipTest('ctypes or kernel32 is not available')
|
||||
else:
|
||||
@contextlib.contextmanager
|
||||
def subst_drive(path):
|
||||
"""Temporarily yield a substitute drive for a given path."""
|
||||
for c in reversed(string.ascii_uppercase):
|
||||
drive = f'{c}:'
|
||||
if (not kernel32.QueryDosDeviceW(drive, None, 0) and
|
||||
ctypes.get_last_error() == ERROR_FILE_NOT_FOUND):
|
||||
break
|
||||
else:
|
||||
raise unittest.SkipTest('no available logical drive')
|
||||
if not kernel32.DefineDosDeviceW(
|
||||
DDD_NO_BROADCAST_SYSTEM, drive, path):
|
||||
raise ctypes.WinError(ctypes.get_last_error())
|
||||
try:
|
||||
yield drive
|
||||
finally:
|
||||
if not kernel32.DefineDosDeviceW(
|
||||
DDD_REMOVE_DEFINITION | DDD_EXACT_MATCH_ON_REMOVE,
|
||||
drive, path):
|
||||
raise ctypes.WinError(ctypes.get_last_error())
|
||||
|
|
|
@ -2973,6 +2973,26 @@ class WindowsPathTest(_BasePathTest, unittest.TestCase):
|
|||
self.assertEqual(str(P('a', 'b', 'c').absolute()),
|
||||
os.path.join(share, 'a', 'b', 'c'))
|
||||
|
||||
drive = os.path.splitdrive(BASE)[0]
|
||||
with os_helper.change_cwd(BASE):
|
||||
# Relative path with root
|
||||
self.assertEqual(str(P('\\').absolute()), drive + '\\')
|
||||
self.assertEqual(str(P('\\foo').absolute()), drive + '\\foo')
|
||||
|
||||
# Relative path on current drive
|
||||
self.assertEqual(str(P(drive).absolute()), BASE)
|
||||
self.assertEqual(str(P(drive + 'foo').absolute()), os.path.join(BASE, 'foo'))
|
||||
|
||||
with os_helper.subst_drive(BASE) as other_drive:
|
||||
# Set the working directory on the substitute drive
|
||||
saved_cwd = os.getcwd()
|
||||
other_cwd = f'{other_drive}\\dirA'
|
||||
os.chdir(other_cwd)
|
||||
os.chdir(saved_cwd)
|
||||
|
||||
# Relative path on another drive
|
||||
self.assertEqual(str(P(other_drive).absolute()), other_cwd)
|
||||
self.assertEqual(str(P(other_drive + 'foo').absolute()), other_cwd + '\\foo')
|
||||
|
||||
def test_glob(self):
|
||||
P = self.cls
|
||||
|
|
|
@ -0,0 +1,3 @@
|
|||
Fix handling of drive-relative paths (like 'C:' and 'C:foo') in
|
||||
:meth:`pathlib.Path.absolute`. This method now uses the OS API
|
||||
to retrieve the correct current working directory for the drive.
|
Loading…
Add table
Add a link
Reference in a new issue