mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-27 04:05:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #5437: A preallocated MemoryError instance should not hold traceback

Browse source 
data (including local variables caught in the stack trace) alive infinitely.
This commit is contained in:
Antoine Pitrou 2010-10-28 22:56:58 +00:00
parent 1842d0c4d8
commit 07e20ef50b
5 changed files with 130 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Python/errors.c
View file

@ -333,29 +333,7 @@ PyErr_BadArgument(void)
PyObject *
PyErr_NoMemory(void)
{
if (PyErr_ExceptionMatches(PyExc_MemoryError))
/* already current */
return NULL;
/* raise the pre-allocated instance if it still exists */
if (PyExc_MemoryErrorInst)
{
/* Clear the previous traceback, otherwise it will be appended
* to the current one.
*
* The following statement is not likely to raise any error;
* if it does, we simply discard it.
*/
PyException_SetTraceback(PyExc_MemoryErrorInst, Py_None);
PyErr_SetObject(PyExc_MemoryError, PyExc_MemoryErrorInst);
}
else
/* this will probably fail since there's no memory and hee,
hee, we have to instantiate this class
*/
PyErr_SetNone(PyExc_MemoryError);
PyErr_SetNone(PyExc_MemoryError);
return NULL;
}