mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-33203: Ensure random.choice always raises IndexError on empty sequence (GH-6338)

Browse source
This commit is contained in:
Wolfgang Maier 2018-04-05 17:19:44 +02:00 • committed by Raymond Hettinger
parent 74940913d2
commit 091e95e900
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/random.py
View file

@ -242,6 +242,8 @@ class Random(_random.Random):
"enough bits to choose from a population range this large.\n"
"To remove the range limitation, add a getrandbits() method.")
return int(random() * n)
if n == 0:
raise ValueError("Boundary cannot be zero")
rem = maxsize % n
limit = (maxsize - rem) / maxsize # int(limit * maxsize) % n == 0
r = random()